fix for cross site authentication #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrjoes
added a commit
that referenced
this pull request
Dec 14, 2011
fix for cross site authentication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using xhr transports, "cookie" may not already be in headers for preflight request.
If request needs cookies to be set/sent, that check will result in 'Access-Control-Allow-Credentials' not being set.
Also, at least in Chrome/Firefox, setting header to value of True will result in it not being detected properly and you'll get a
Credentials flag is true, but Access-Control-Allow-Credentials is not "true"error. 'Access-Control-Allow-Credentials' needs to be set to 'true'reference socketio/socket.io-client#335