-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to vaccination #59
Conversation
adult_ind_raw -> 1 - is_child
…s separately this is now moved to the line where they are combined
…tisation and 3) target reached or not
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
==========================================
+ Coverage 88.28% 88.38% +0.10%
==========================================
Files 8 8
Lines 1647 1653 +6
==========================================
+ Hits 1454 1461 +7
+ Misses 193 192 -1 ☔ View full report in Codecov by Sentry. |
before you both review I'll merge Lilith's PR in to avoid any more hiccups |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Very minor suggestion about using one of the new objects you define rather than repeating the calc, but otherwise looks good to me, and next checking steps are probably best done graphically
Co-authored-by: edknock <47318334+edknock@users.noreply.github.com>
Co-authored-by: Lilith Whittles <lwhittles@users.noreply.github.com>
Co-authored-by: Lilith Whittles <lwhittles@users.noreply.github.com>
Co-authored-by: Lilith Whittles <lwhittles@users.noreply.github.com>
Please can I ask that you both review this just to be safe? I am extra concerned about vaccination due to all of the problems we've had
As discussed in the meeting on 8/1, this PR attempts to correct the following issues: