Add tabs generation logic for the tabs iOS integration #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 13, 2022
tarikeshaq
approved these changes
May 19, 2022
There was a problem hiding this comment.
Approving this for whenever we want to land it 😄 LGTM
(if we end up adding a new metrics.yaml in application-services we'll want to add it to https://github.com/mozilla/rust-components-swift/blob/main/generate.sh#L34 but otherwise 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logic to generate the tabs logic for iOS. It should not be merged until an application services release has been cut that includes AS #4905. This PR also blocks Firefox iOS PR #10553.