Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tabs component for iOS integration #4905

Merged
merged 1 commit into from
May 24, 2022
Merged

Update tabs component for iOS integration #4905

merged 1 commit into from
May 24, 2022

Conversation

lougeniaC64
Copy link
Contributor

@lougeniaC64 lougeniaC64 commented Apr 18, 2022

This PR includes a few updates to the tab component to allow the integration of the tabs component in iOS. It includes:

  • Resolving the naming conflict of the DeviceType enum that is exposed in FxA and Tabs which prevented rust-components-swift from generating Tabs code
  • Exposing the tabs reset function and errors
  • Updating the sync function's parameters to match the SyncUnlockInfo parameters
  • Fixing the tabs sync example

Note: This PR blocks RCS PR #58 and Firefox iOS PR #10553.

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGES_UNRELEASED.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2022

Codecov Report

Merging #4905 (9e4d294) into main (db4b048) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #4905      +/-   ##
==========================================
- Coverage   38.56%   38.51%   -0.06%     
==========================================
  Files         166      166              
  Lines       12389    12407      +18     
==========================================
  Hits         4778     4778              
- Misses       7611     7629      +18     
Impacted Files Coverage Δ
components/tabs/src/error.rs 0.00% <0.00%> (ø)
components/tabs/src/storage.rs 0.00% <ø> (ø)
components/tabs/src/sync/store.rs 0.00% <0.00%> (ø)
examples/cli-support/src/fxa_creds.rs 0.00% <0.00%> (ø)
examples/tabs-sync/src/tabs-sync.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db4b048...9e4d294. Read the comment docs.

@lougeniaC64 lougeniaC64 force-pushed the tabs-for-ios branch 6 times, most recently from 520c145 to d235d7c Compare April 18, 2022 22:15
@lougeniaC64 lougeniaC64 changed the title Updates for iOS tabs component integration [WIP] Updates for iOS tabs component integration Apr 18, 2022
Copy link
Member

@mhammond mhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only had time for a quick look/think, and I think this will be fine if necessary, but working out a better story for that type would be ideal! Also welcome your thoughts on having more functions return those tab errors? Or maybe sync should just log and swallow them too, making the error changes unnecessary? Not sure which one is best, but this new "mixed-messages" model seems less than ideal!

@lougeniaC64 lougeniaC64 force-pushed the tabs-for-ios branch 2 times, most recently from 4c21029 to 47a1d8b Compare April 26, 2022 18:28
@lougeniaC64 lougeniaC64 force-pushed the tabs-for-ios branch 2 times, most recently from b1a4ac7 to c2c3f0d Compare May 13, 2022 19:14
@lougeniaC64 lougeniaC64 changed the title [WIP] Updates for iOS tabs component integration Update tabs component for iOS integration May 13, 2022
@lougeniaC64 lougeniaC64 marked this pull request as ready for review May 13, 2022 19:53
@lougeniaC64 lougeniaC64 requested review from mhammond and nbhasin2 May 13, 2022 19:54
Copy link
Member

@mhammond mhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

@lougeniaC64 lougeniaC64 force-pushed the tabs-for-ios branch 2 times, most recently from 95d0deb to fd913d9 Compare May 16, 2022 21:55
@lougeniaC64
Copy link
Contributor Author

@nbhasin2 I'd appreciate your review of the Tabs.swift file in this PR.

@lougeniaC64 lougeniaC64 merged commit 0f8a0f3 into main May 24, 2022
@lougeniaC64 lougeniaC64 deleted the tabs-for-ios branch May 24, 2022 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants