-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tabs component for iOS integration #4905
Conversation
2acdf8a
to
59a5a64
Compare
Codecov Report
@@ Coverage Diff @@
## main #4905 +/- ##
==========================================
- Coverage 38.56% 38.51% -0.06%
==========================================
Files 166 166
Lines 12389 12407 +18
==========================================
Hits 4778 4778
- Misses 7611 7629 +18
Continue to review full report at Codecov.
|
520c145
to
d235d7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only had time for a quick look/think, and I think this will be fine if necessary, but working out a better story for that type would be ideal! Also welcome your thoughts on having more functions return those tab errors? Or maybe sync should just log and swallow them too, making the error changes unnecessary? Not sure which one is best, but this new "mixed-messages" model seems less than ideal!
components/tabs/android/src/main/java/mozilla/appservices/tabs/DeviceType.kt
Show resolved
Hide resolved
d235d7c
to
7bc2af6
Compare
4c21029
to
47a1d8b
Compare
b1a4ac7
to
c2c3f0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚢
95d0deb
to
fd913d9
Compare
@nbhasin2 I'd appreciate your review of the Tabs.swift file in this PR. |
This PR includes a few updates to the tab component to allow the integration of the tabs component in iOS. It includes:
DeviceType
enum that is exposed in FxA and Tabs which preventedrust-components-swift
from generating Tabs codereset
function and errorsSyncUnlockInfo
parametersNote: This PR blocks RCS PR #58 and Firefox iOS PR #10553.
Pull Request checklist
[ci full]
to the PR title.