-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the overflowing text special-case from scrollIntoView
(issue 15714)
#15721
Conversation
… 15714) With the changes made in PR 14564 this *should* no longer be necessary now, however we still need to keep the `scrollMatches` parameter to handle textLayers with markedContent correctly when searching.
@calixteman For testing purposes, you should have access to PDF document from issue #5355 in the archive I sent you earlier. /botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/cc3261129dae4bd/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/80e5d4a2b81cbb2/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/cc3261129dae4bd/output.txt Total script time: 4.12 mins
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/17fe14d3cf63079/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/17fe14d3cf63079/output.txt Total script time: 1.26 mins Published |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/80e5d4a2b81cbb2/output.txt Total script time: 42.49 mins
|
/botio-windows integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/ea1e190996ba2b3/output.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/ea1e190996ba2b3/output.txt Total script time: 50.88 mins
|
With the changes made in PR #14564 this should no longer be necessary now, however we still need to keep the
scrollMatches
parameter to handle textLayers with markedContent correctly when searching.