Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Functionality Highlighting in white space #15739

Closed
Yash7032 opened this issue Nov 24, 2022 · 4 comments · Fixed by #15740
Closed

Search Functionality Highlighting in white space #15739

Yash7032 opened this issue Nov 24, 2022 · 4 comments · Fixed by #15740

Comments

@Yash7032
Copy link

Attach (recommended) or Link to PDF file here:
https://mozilla.github.io/pdf.js/web/viewer.html
Configuration:

Steps to reproduce the problem:

  1. Browse the site and search for "For" text - https://mozilla.github.io/pdf.js/web/viewer.html
  2. which will highlight in white space

What is the expected behavior? (add screenshot)
Searching for text "for" and it got highlighted in while space
What went wrong? (add screenshot)
image

Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):
https://mozilla.github.io/pdf.js/web/viewer.html

@Snuffleupagus
Copy link
Collaborator

Effectively a duplicate of #15736; unfortunately there must be some setting in your browser that affect e.g. the font-size or position of the textLayer-elements.

@calixteman
Copy link
Contributor

calixteman commented Nov 24, 2022

I can reproduce (even with the local dev server) on Edge and Chrome.

@Snuffleupagus
Copy link
Collaborator

Snuffleupagus commented Nov 24, 2022

I can reproduce (even with the local dev server) on Edge and Chrome and it should be fixed by

Oh, if it affects Chromium generally there's a pretty good chance that it's actually a regression :-(
Most likely PR #15721 affected Chromium browsers, although Firefox obviously is fine; given that the next PDF.js release is likely this weekend I'll just revert that one for now.

@calixteman
Copy link
Contributor

FYI, #15722 isn't fixing the regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants