Add typing stubs to pre-commit mypy run #3266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akkomar
commented
Oct 11, 2022
akkomar
commented
Oct 11, 2022
Comment on lines
+35
to
+40
| additional_dependencies: [types-pytz==2022.4.0.0, | ||
| types-ujson==5.5.0, | ||
| types-python-dateutil==2.8.19, | ||
| types-requests==2.28.11.2, | ||
| types-attrs==19.1.0, | ||
| types-PyYAML==6.0.12] |
There was a problem hiding this comment.
These are actually duplicates of values from requirements.in which is not great.
There was a problem hiding this comment.
I did notice types-attrs does not seem to be in the requirements file. I will try and see if adding it there is enough.
There was a problem hiding this comment.
looks like we need to specify the additional_dependencies...
Integration report for "Lint"
|
Integration report for "Lint"
|
|
I can confirm using this config solves the errors on my machine |
kik-kik
approved these changes
Oct 11, 2022
relud
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to https://mozilla.slack.com/archives/C01E8GDG80N/p1665434432654689
We've seen mypy pre-commit hook failing and complaining about missing library stubs for some of the dependencies. Per pre-commit mirror docs it runs in an isolated environment so it seems to be making sense.
The issue might be related to #3248.
Changes proposed here do fix the mypy hook run for me on Python 3.10.7. However since I don't understand why we're seeing these errors I am not entirely sure if the local environment (mine and @kik-kik ) isn't at fault here.
Checklist for reviewer:
<username>:<branch>of the fork as parameter. The parameter will also show upin the logs of the
manual-trigger-required-for-forkCI task together with more detailed instructions.For modifications to schemas in restricted namespaces (see
CODEOWNERS):