Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI to python 3.10 #3248

Merged
merged 5 commits into from
Oct 5, 2022
Merged

Update CI to python 3.10 #3248

merged 5 commits into from
Oct 5, 2022

Conversation

relud
Copy link
Collaborator

@relud relud commented Oct 5, 2022 •
edited
Loading

follow-up from #3236
blocks #3246

updates mypy to pick up fix for python/mypy#13627

@relud relud requested a review from fbertsch October 5, 2022 16:35
@dataops-ci-bot
Copy link

Integration report for "Update CI to python 3.10"

sql.diff

Click to expand! 
diff -bur --no-dereference bigquery-etl-main/sql/moz-fx-data-shared-prod/telemetry/clients_daily/schema.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry/clients_daily/schema.yaml
--- bigquery-etl-main/sql/moz-fx-data-shared-prod/telemetry/clients_daily/schema.yaml	2022-10-05 16:46:47.121697451 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry/clients_daily/schema.yaml	2022-10-05 16:39:04.000000000 +0000
@@ -2,71 +2,94 @@
 - mode: NULLABLE
   name: submission_date_s3
   type: DATE
-- mode: NULLABLE
+- description: null
+  mode: NULLABLE
   name: submission_date
   type: DATE
-- mode: NULLABLE
+- description: null
+  mode: NULLABLE
   name: client_id
   type: STRING
-- mode: NULLABLE
+- description: null
+  mode: NULLABLE
   name: aborts_content_sum
   type: INTEGER
-- mode: NULLABLE
+- description: null
+  mode: NULLABLE
   name: aborts_gmplugin_sum
   type: INTEGER
-- mode: NULLABLE
+- description: null
+  mode: NULLABLE
   name: aborts_plugin_sum
   type: INTEGER
-- mode: NULLABLE
+- description: null
+  mode: NULLABLE
   name: active_addons_count_mean
   type: FLOAT
-- fields:
-  - mode: NULLABLE
+- description: null
+  fields:
+  - description: null
+    mode: NULLABLE
     name: addon_id
     type: STRING
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: blocklisted
     type: BOOLEAN
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: name
     type: STRING
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: user_disabled
     type: BOOLEAN
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: app_disabled
     type: BOOLEAN
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: version
     type: STRING
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: scope
     type: INTEGER
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: type
     type: STRING
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: foreign_install
     type: BOOLEAN
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: has_binary_components
     type: BOOLEAN
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: install_day
     type: INTEGER
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: update_day
     type: INTEGER
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: signed_state
     type: INTEGER
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: is_system
     type: BOOLEAN
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: is_web_extension
     type: BOOLEAN
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: multiprocess_compatible
     type: BOOLEAN
   mode: REPEATED

@dataops-ci-bot
Copy link

Integration report for "Install python deps in verify-format-sql job"

sql.diff

Click to expand! 
diff -bur --no-dereference bigquery-etl-main/sql/moz-fx-data-shared-prod/telemetry/clients_daily/schema.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry/clients_daily/schema.yaml
--- bigquery-etl-main/sql/moz-fx-data-shared-prod/telemetry/clients_daily/schema.yaml	2022-10-05 16:58:18.318172047 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry/clients_daily/schema.yaml	2022-10-05 16:50:29.000000000 +0000
@@ -2,71 +2,94 @@
 - mode: NULLABLE
   name: submission_date_s3
   type: DATE
-- mode: NULLABLE
+- description: null
+  mode: NULLABLE
   name: submission_date
   type: DATE
-- mode: NULLABLE
+- description: null
+  mode: NULLABLE
   name: client_id
   type: STRING
-- mode: NULLABLE
+- description: null
+  mode: NULLABLE
   name: aborts_content_sum
   type: INTEGER
-- mode: NULLABLE
+- description: null
+  mode: NULLABLE
   name: aborts_gmplugin_sum
   type: INTEGER
-- mode: NULLABLE
+- description: null
+  mode: NULLABLE
   name: aborts_plugin_sum
   type: INTEGER
-- mode: NULLABLE
+- description: null
+  mode: NULLABLE
   name: active_addons_count_mean
   type: FLOAT
-- fields:
-  - mode: NULLABLE
+- description: null
+  fields:
+  - description: null
+    mode: NULLABLE
     name: addon_id
     type: STRING
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: blocklisted
     type: BOOLEAN
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: name
     type: STRING
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: user_disabled
     type: BOOLEAN
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: app_disabled
     type: BOOLEAN
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: version
     type: STRING
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: scope
     type: INTEGER
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: type
     type: STRING
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: foreign_install
     type: BOOLEAN
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: has_binary_components
     type: BOOLEAN
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: install_day
     type: INTEGER
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: update_day
     type: INTEGER
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: signed_state
     type: INTEGER
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: is_system
     type: BOOLEAN
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: is_web_extension
     type: BOOLEAN
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: multiprocess_compatible
     type: BOOLEAN
   mode: REPEATED

@dataops-ci-bot
Copy link

Integration report for "Configure mypy to ignore venv"

sql.diff

Click to expand! 
diff -bur --no-dereference bigquery-etl-main/sql/moz-fx-data-shared-prod/telemetry/clients_daily/schema.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry/clients_daily/schema.yaml
--- bigquery-etl-main/sql/moz-fx-data-shared-prod/telemetry/clients_daily/schema.yaml	2022-10-05 17:28:24.202657321 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry/clients_daily/schema.yaml	2022-10-05 17:20:09.000000000 +0000
@@ -2,71 +2,94 @@
 - mode: NULLABLE
   name: submission_date_s3
   type: DATE
-- mode: NULLABLE
+- description: null
+  mode: NULLABLE
   name: submission_date
   type: DATE
-- mode: NULLABLE
+- description: null
+  mode: NULLABLE
   name: client_id
   type: STRING
-- mode: NULLABLE
+- description: null
+  mode: NULLABLE
   name: aborts_content_sum
   type: INTEGER
-- mode: NULLABLE
+- description: null
+  mode: NULLABLE
   name: aborts_gmplugin_sum
   type: INTEGER
-- mode: NULLABLE
+- description: null
+  mode: NULLABLE
   name: aborts_plugin_sum
   type: INTEGER
-- mode: NULLABLE
+- description: null
+  mode: NULLABLE
   name: active_addons_count_mean
   type: FLOAT
-- fields:
-  - mode: NULLABLE
+- description: null
+  fields:
+  - description: null
+    mode: NULLABLE
     name: addon_id
     type: STRING
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: blocklisted
     type: BOOLEAN
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: name
     type: STRING
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: user_disabled
     type: BOOLEAN
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: app_disabled
     type: BOOLEAN
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: version
     type: STRING
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: scope
     type: INTEGER
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: type
     type: STRING
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: foreign_install
     type: BOOLEAN
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: has_binary_components
     type: BOOLEAN
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: install_day
     type: INTEGER
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: update_day
     type: INTEGER
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: signed_state
     type: INTEGER
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: is_system
     type: BOOLEAN
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: is_web_extension
     type: BOOLEAN
-  - mode: NULLABLE
+  - description: null
+    mode: NULLABLE
     name: multiprocess_compatible
     type: BOOLEAN
   mode: REPEATED

@dataops-ci-bot

This comment was marked as outdated.

Sign in to view
relud
relud commented Oct 5, 2022
View reviewed changes
.circleci/config.yml
Comment on lines 60 to +61
- *restore_venv_cache
- *build
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updating the cache keys revealed that this was missing, but restore_venv_cache was providing the required dependencies

@relud relud removed the request for review from fbertsch October 5, 2022 17:54
fbertsch
fbertsch approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@fbertsch fbertsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc, thank you for the followup!

.circleci/config.yml Outdated Show resolved Hide resolved
@dataops-ci-bot
Copy link

Integration report for "Update mypy for python 3.10.7 support"

sql.diff

Click to expand! 
Only in /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/monitoring/stable_table_sizes: schema.yaml
Only in /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/monitoring/structured_missing_columns: schema.yaml

@relud relud enabled auto-merge (squash) October 5, 2022 18:31
@relud relud merged commit 797ac94 into main Oct 5, 2022
@relud relud deleted the ci-python-3.10 branch October 5, 2022 18:32
@akkomar akkomar mentioned this pull request Oct 11, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbertsch fbertsch fbertsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@relud @dataops-ci-bot @fbertsch