Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite generate_package.py in C++ to avoid training dependencies #3113

Merged
merged 9 commits into from
Jul 2, 2020
Merged

Rewrite generate_package.py in C++ to avoid training dependencies #3113

merged 9 commits into from
Jul 2, 2020

Conversation

reuben
Copy link
Contributor

@reuben reuben commented Jun 28, 2020

No description provided.

@reuben reuben force-pushed the generate-package-cpp branch from f947ba5 to 722d604 Compare June 29, 2020 08:34
reuben
reuben commented Jun 29, 2020
View reviewed changes
taskcluster/tc-package.sh Outdated Show resolved Hide resolved
reuben
reuben commented Jun 29, 2020
View reviewed changes
native_client/Android.mk Outdated Show resolved Hide resolved
@reuben reuben force-pushed the generate-package-cpp branch 3 times, most recently from 16220b5 to f5ce155 Compare June 29, 2020 19:34
@reuben reuben requested a review from lissyx June 29, 2020 21:20
@reuben
Copy link
Contributor Author

reuben commented Jun 29, 2020 •
edited
Loading

All green!

@reuben reuben force-pushed the generate-package-cpp branch from f5ce155 to 8f6106b Compare June 30, 2020 14:47
@reuben reuben mentioned this pull request Jun 30, 2020
Closed
lissyx
lissyx reviewed Jul 1, 2020
View reviewed changes
data/README.rst Outdated Show resolved Hide resolved
lissyx
lissyx reviewed Jul 1, 2020
View reviewed changes
doc/Scorer.rst Show resolved Hide resolved
lissyx
lissyx reviewed Jul 1, 2020
View reviewed changes
doc/Scorer.rst Outdated Show resolved Hide resolved
lissyx
lissyx reviewed Jul 1, 2020
View reviewed changes
taskcluster/.shared.yml Outdated Show resolved Hide resolved
lissyx
lissyx reviewed Jul 2, 2020
View reviewed changes
data/README.rst
@@ -3,7 +3,7 @@ Language-Specific Data

This directory contains language-specific data files. Most importantly, you will find here:

1. A list of unique characters for the target language (e.g. English) in ``data/alphabet.txt``
1. A list of unique characters for the target language (e.g. English) in ``data/alphabet.txt``. After installing the training code, you can check ``python -m deepspeech_training.util.check_characters --help`` for a tool that creates an alphabet file from a list of training CSV files.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@reuben reuben merged commit d2d46c3 into master Jul 2, 2020
@reuben reuben deleted the generate-package-cpp branch July 2, 2020 21:13
@reuben reuben mentioned this pull request Jul 3, 2020
Closed
@tilmankamp tilmankamp mentioned this pull request Jul 3, 2020
Merged
@reuben reuben mentioned this pull request Aug 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lissyx lissyx lissyx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reuben @lissyx