Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for DeepSpeech 0.7.x (WIP) #32

Merged
merged 7 commits into from
Jul 3, 2020
Merged

Support for DeepSpeech 0.7.x (WIP) #32

merged 7 commits into from
Jul 3, 2020

Conversation

BoneGoat
Copy link
Contributor

@BoneGoat BoneGoat commented Jun 26, 2020 •
edited
Loading

This is still WIP but works with DS 0.7.1.

@shivam-learngram-ai shivam-learngram-ai mentioned this pull request Jun 26, 2020
Closed
@BoneGoat BoneGoat mentioned this pull request Jun 27, 2020
Closed
@tilmankamp
Copy link
Contributor

@BoneGoat mozilla/DeepSpeech#3113 introduced a different way to generate scorers. https://github.com/mozilla/DeepSpeech/blob/master/doc/Scorer.rst has instructions on how this works. As I also had to update documentation you have to re-base now. Sorry for this. I vote for simply re-basing this PR and merging it now, as it's already much better than the current state in master. One could go from there to update to the new scorer building approach.

tilmankamp
tilmankamp approved these changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@tilmankamp tilmankamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already better than current master

@tilmankamp
Copy link
Contributor

@BoneGoat Should I merge it?

@BoneGoat
Copy link
Contributor Author

BoneGoat commented Jul 3, 2020

@BoneGoat Should I merge it?

Now it should be fine. Thanks!

@tilmankamp
Copy link
Contributor

@BoneGoat It seems that something went wrong with the re-base. All my recent documentation changes get repeated by your PR - could you check what happened there?

@BoneGoat
Copy link
Contributor Author

BoneGoat commented Jul 3, 2020

@BoneGoat It seems that something went wrong with the re-base. All my recent documentation changes get repeated by your PR - could you check what happened there?

Yeah, just noticed that. I'll check. Sorry about that.

@BoneGoat
Copy link
Contributor Author

BoneGoat commented Jul 3, 2020

@tilmankamp OK, that should do it.

@tilmankamp tilmankamp merged commit e9ae8b7 into mozilla:master Jul 3, 2020
@tilmankamp
Copy link
Contributor

Thanks!

This was referenced Jul 3, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tilmankamp tilmankamp tilmankamp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BoneGoat @tilmankamp