chore: tag 1.71.7 #773
Merged
chore: tag 1.71.7 #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I took a stab at updating the CircleCI config to push images to GAR after they're pushed to Docker Hub. This approach requires the [circleci/gcp-gcr orb](https://circleci.com/developer/orbs/orb/circleci/gcp-gcr). Requirements: - [x] New environment variables added to CircleCI project - [x] Workload Identity configured for service account - [ ] New workflows tested
This value was defaulting to `false`, causing the orb to expect a service account key to be present. --------- Co-authored-by: JR Conlin <jr+git@mozilla.com>
#762) I was accidentally using the GAR project ID for both OIDC and GAR. I updated this workflow to: - Use the correct values for each respective project ID - Rename the environment variables so their scopes are clearer (GAR vs OIDC) I already updated the corresponding environment variables on CircleCI.
I was not passing in a necessary parameter for OIDC authentication. It turns out the orb differentiates between the project ID (project to make changes against) and project number (OIDC Workload Identity authorization).
This now mounts the workspace so we can load the built image from that. Also, I fixed the image name in the `gcp-gcr/push-image` step. This was tested successfully in https://app.circleci.com/pipelines/github/mozilla-services/autopush-rs/2873/workflows/9adebe2f-13e8-4e5d-a853-e78b7f6ca368
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and rebuild Cargo.lock, resolve cherry-picking/merge conflicts