Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added missing use_oidc gcr-auth param #761

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Conversation

emaydeck-mozilla
Copy link
Contributor

This value was defaulting to false, causing the orb to expect a service account key to be present.

taddes
taddes previously approved these changes Sep 4, 2024
Copy link
Contributor

@taddes taddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍 , will take note for the future in case there are future issues.

@jrconlin
Copy link
Member

jrconlin commented Sep 4, 2024

We should probably add a comment pointing folk to where all these values are defined (and what the defaults are). I can see this coming back to haunt us eventually, so leaving a trail might be useful.

@emaydeck-mozilla
Copy link
Contributor Author

We should probably add a comment pointing folk to where all these values are defined (and what the defaults are). I can see this coming back to haunt us eventually, so leaving a trail might be useful.

Done! 3805e69

@emaydeck-mozilla emaydeck-mozilla merged commit b3740a8 into master Sep 4, 2024
1 check passed
@emaydeck-mozilla emaydeck-mozilla deleted the RRM-181 branch September 4, 2024 19:55
pjenvey pushed a commit that referenced this pull request Sep 5, 2024
This value was defaulting to `false`, causing the orb to expect a
service account key to be present.

---------

Co-authored-by: JR Conlin <jr+git@mozilla.com>
emaydeck-mozilla added a commit that referenced this pull request Sep 5, 2024
This value was defaulting to `false`, causing the orb to expect a
service account key to be present.

---------

Co-authored-by: JR Conlin <jr+git@mozilla.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants