Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added missing use_oidc gcr-auth param #761

Merged
merged 3 commits into from
Sep 4, 2024
Merged

chore: added missing use_oidc gcr-auth param #761

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b14185
chore: added missing use_oidc gcr-auth param
emaydeck-mozilla Sep 4, 2024
25a9ede
Merge branch 'master' into RRM-181
jrconlin Sep 4, 2024
3805e69
chore: added comments with gcp-gcr orb doc refs
emaydeck-mozilla Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,11 +424,14 @@ jobs:
type: string
default: us-docker.pkg.dev
steps:
# gcr-auth parameters:
# https://circleci.com/developer/orbs/orb/circleci/gcp-gcr#commands-gcr-auth
- gcp-gcr/gcr-auth:
gcp_cred_config_file_path: ~/gcp_cred_config.json
google-project-id: GCP_PROJECT_ID
registry-url: <<parameters.registry-url>>
service_account_email: GCP_SERVICE_ACCOUNT_EMAIL
use_oidc: true
workload_identity_pool_id: GCP_WIP_ID
workload_identity_pool_provider_id: GCP_WIP_PROVIDER_ID
- run:
Expand All @@ -443,6 +446,8 @@ jobs:
source $BASH_ENV
docker tag <<parameters.image>>:<<parameters.build_tag>> $GAR_IMAGE:$GAR_TAG
docker tag <<parameters.image>>:<<parameters.build_tag>> $GAR_IMAGE:latest
# push-image parameters:
# https://circleci.com/developer/orbs/orb/circleci/gcp-gcr#commands-push-image
- gcp-gcr/push-image:
image: $GAR_IMAGE
google-project-id: GCP_PROJECT_ID
Expand Down