[DO NOT MERGE] mcomella PR 2 to test TC fixes!!! #2501

mcomella · 2019-07-08T22:50:19Z

Connected to #2378. GitHub forced closed my last PR #2459 so I had to make a new one. See that PR's comments for my previous findings.

Testing and Review Notes

Screenshots or Videos

Checklist

Confirm the acceptance criteria is/are fully satisfied in the issue(s) this PR will close
Add testing notes and/or screenshots in PR description to help guide all potential reviewers
Add thorough tests or an explanation of why it does not
Add a CHANGELOG entry if applicable
Add QA labels on the associated issue (not this PR; qa-ready or qa-denied)

… Overlay

…for Overlay

…rlay is active

…ocusRepo

…c in overlay fragment

…po.State

…wnViewById()

…t of State

…ences

…iewModels

…onDestroyView

…eenChange

…to focusRequests

For gecko vs. webview checks

Looking through the changelog, there do not appear to be any changes that should affect us.

…king changes. I was unable to update detekt because there were too many errors I don't have time to deal with right now.

…change app behavior.

Noticed PM has been filing a different format for features so matching that here. Also adding continuity for releng checklist making.

…teView The old implementation caused obscure bugs. Now we have moved to the latest version of Activity.onCreateView giving better compatibility. The new parameter was specified nullable as google specifies that the argument may be null.

mcomella · 2019-07-08T22:53:36Z

I pushed v3.10-LAT4: 1/2 (pass/runs).

I got v3.11 to fail (2/3) but v3.10 did not (4/4 or 5/5). However, the first merge to master that failed is one commit before v3.10-LAT4 4641e17 so I'm making sure I can reproduce on v3.10-LAT4 before I begin to check earlier commits.

mcomella · 2019-07-09T00:25:04Z

v3.10-LAT4 failed so the change must have happened before then.

I pushed 45bead4: 8/8 (successes/runs). This is before we upgraded the dependencies we initially suspected in late, late May.

mcomella · 2019-07-09T13:46:10Z

45bead4 hasn't failed so I'd like to bisect through the changes between that and v3.10-LAT4 that have changed the tests. It looks like there are only a few issues that changed the tests (with many micro-commits):

I pushed the last test commit in #2325, 14f1d0b: 0/1 (success/runs).

mcomella · 2019-07-09T14:50:39Z

14f1d0b failed so the failure is before then but after 45bead4: that's only a handful of commits left.

I pushed 2344fce, which is before #2325 landed: 4/4 (success/runs) though 1 UI test failure.

mcomella · 2019-07-09T18:49:41Z

Most likely root cause found in #2505. Closing.

psymoon and others added 30 commits April 30, 2019 15:17

Issue mozilla-mobile#1395: Add FocusRepo.Event

948ba82

Issue mozilla-mobile#1395: Add transition to Pocket default focus for…

f4751d7

… Overlay

Issue mozilla-mobile#1395: Add transition to WebRender default focus …

66fa29a

…for Overlay

Issue mozilla-mobile#1395: Handle default focus for Overlay

88d2721

Issue mozilla-mobile#1395: Move defaultFocusMap update to when NavOve…

f399ef1

…rlay is active

Issue mozilla-mobile#1395: Handle checkIfTilesFocusNeedRefresh() in F…

4ecd3b2

…ocusRepo

Issue mozilla-mobile#1395: Handle PocketTryAgain lost focus

55db000

Issue mozilla-mobile#1395: Handle lost focus case

b0007aa

Issue mozilla-mobile#1395: Remove all remaining deprecated focus logi…

92b9344

…c in overlay fragment

Issue mozilla-mobile#1395: Add WebRenderViewModel

b285231

Issue mozilla-mobile#1395: Hook up WebRenderVM to FocusRepo

84cc980

Issue mozilla-mobile#1395: Remove activeScreen reference from FocusRe…

1c9b08a

…po.State

Issue mozilla-mobile#1395: Update INVALID_VIEW_ID and add validateKno…

d4488e6

…wnViewById()

Issue mozilla-mobile#1395: Move RequestFocus event to a State

27fba32

Issue mozilla-mobile#1395: Remove Event + take out defaultFocusMap ou…

3befb4b

…t of State

Issue mozilla-mobile#1395: Fix ActiveScreen import

898e57b

Issue mozilla-mobile#1395: Remove prevScreen + FocusRepo.events refer…

e701aca

…ences

Issue mozilla-mobile#1395: Add defaultViewAfterScreenChange

84c0d91

Issue mozilla-mobile#1395: Add defaultViewAfterScreenChange to each V…

f70866f

…iewModels

Issue mozilla-mobile#1395: Make rootView nullable and clean it up in …

c057066

…onDestroyView

Issue mozilla-mobile#1395: Expose ActiveScreen in defaultViewAfterScr…

de78146

…eenChange

Issue mozilla-mobile#1395: Move EngineView.focusedDOMElement.cache() …

f8c9a48

…to focusRequests

Issue mozilla-mobile#1395: Move validateKnownViewById to view.ext

5cd2e81

For gecko vs. webview checks

Issue mozilla-mobile#1395: FocusRepo cleanup + address nits

161a9d2

Closes mozilla-mobile#1395: Rename _state to _focusedView

c38cf96

Issue mozilla-mobile#2110: updated PinnedTileViewModel from LD -> Rx

66a11c1

Issue mozilla-mobile#2110: fixed PinnedTileViewModelTest

9066aab

No issue: version bump to 3.9-LAT1

cbfa3f3

Issue mozilla-mobile#2133: Add the hintContainer visiblity logic

9f03b9e

Closes mozilla-mobile#2133: Use AnimatorListenerAdapter

2476444

mcomella and others added 8 commits May 29, 2019 10:31

No issue: add link to automation doc to releng checklist issue template

76a4e8a

Issue mozilla-mobile#2338: Bump version to v3.10-LAT3.

45bead4

Issue mozilla-mobile#2338: upgrade a-c to 0.54.

f18a8b1

Looking through the changelog, there do not appear to be any changes that should affect us.

Issue mozilla-mobile#2338: Update app/build dependencies with no brea…

85bde84

…king changes. I was unable to update detekt because there were too many errors I don't have time to deal with right now.

Issue mozilla-mobile#2338: Update gradle to v5.4.1.

fc3e0c5

Issue mozilla-mobile#2338 - post: Fix android lint errors that don't …

936da59

…change app behavior.

No issue: Update templates for Releng and Feature

51c6f8e

Noticed PM has been filing a different format for features so matching that here. Also adding continuity for releng checklist making.

mcomella mentioned this pull request Jul 8, 2019

[DO NOT MERGE] mcomella PR to test TC fixes! #2459

Closed

3 tasks

mcomella changed the title ~~[DO NOT MERGE] mcomella PR 2 to test TC fixes!~~ [DO NOT MERGE] mcomella PR 2 to test TC fixes!! Jul 8, 2019

mcomella force-pushed the ni-tc-revert2 branch from 58e5bc2 to 45bead4 Compare July 9, 2019 00:23

mcomella changed the title ~~[DO NOT MERGE] mcomella PR 2 to test TC fixes!!~~ [DO NOT MERGE] mcomella PR 2 to test TC fixes! Jul 9, 2019

mcomella changed the title ~~[DO NOT MERGE] mcomella PR 2 to test TC fixes!~~ [DO NOT MERGE] mcomella PR 2 to test TC fixes!! Jul 9, 2019

mcomella changed the title ~~[DO NOT MERGE] mcomella PR 2 to test TC fixes!!~~ [DO NOT MERGE] mcomella PR 2 to test TC fixes!!! Jul 9, 2019

mcomella changed the title ~~[DO NOT MERGE] mcomella PR 2 to test TC fixes!!!~~ [DO NOT MERGE] mcomella PR 2 to test TC fixes Jul 9, 2019

mcomella changed the title ~~[DO NOT MERGE] mcomella PR 2 to test TC fixes~~ [DO NOT MERGE] mcomella PR 2 to test TC fixes! Jul 9, 2019

mcomella changed the title ~~[DO NOT MERGE] mcomella PR 2 to test TC fixes!~~ [DO NOT MERGE] mcomella PR 2 to test TC fixes!! Jul 9, 2019

mcomella changed the title ~~[DO NOT MERGE] mcomella PR 2 to test TC fixes!!~~ [DO NOT MERGE] mcomella PR 2 to test TC fixes!!! Jul 9, 2019

mcomella force-pushed the ni-tc-revert2 branch from 14f1d0b to 2344fce Compare July 9, 2019 14:50

mcomella changed the title ~~[DO NOT MERGE] mcomella PR 2 to test TC fixes!!!~~ [DO NOT MERGE] mcomella PR 2 to test TC fixes Jul 9, 2019

mcomella changed the title ~~[DO NOT MERGE] mcomella PR 2 to test TC fixes~~ [DO NOT MERGE] mcomella PR 2 to test TC fixes! Jul 9, 2019

mcomella changed the title ~~[DO NOT MERGE] mcomella PR 2 to test TC fixes!~~ [DO NOT MERGE] mcomella PR 2 to test TC fixes!! Jul 9, 2019

mcomella changed the title ~~[DO NOT MERGE] mcomella PR 2 to test TC fixes!!~~ [DO NOT MERGE] mcomella PR 2 to test TC fixes!!! Jul 9, 2019

mcomella closed this Jul 9, 2019

mcomella deleted the ni-tc-revert2 branch July 9, 2019 18:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DO NOT MERGE] mcomella PR 2 to test TC fixes!!! #2501

[DO NOT MERGE] mcomella PR 2 to test TC fixes!!! #2501

mcomella commented Jul 8, 2019 •

edited

Loading

mcomella commented Jul 8, 2019 •

edited

Loading

mcomella commented Jul 9, 2019 •

edited

Loading

mcomella commented Jul 9, 2019 •

edited

Loading

mcomella commented Jul 9, 2019 •

edited

Loading

mcomella commented Jul 9, 2019

[DO NOT MERGE] mcomella PR 2 to test TC fixes!!! #2501

[DO NOT MERGE] mcomella PR 2 to test TC fixes!!! #2501

Conversation

mcomella commented Jul 8, 2019 • edited Loading

Testing and Review Notes

Screenshots or Videos

Checklist

mcomella commented Jul 8, 2019 • edited Loading

mcomella commented Jul 9, 2019 • edited Loading

mcomella commented Jul 9, 2019 • edited Loading

mcomella commented Jul 9, 2019 • edited Loading

mcomella commented Jul 9, 2019

mcomella commented Jul 8, 2019 •

edited

Loading

mcomella commented Jul 8, 2019 •

edited

Loading

mcomella commented Jul 9, 2019 •

edited

Loading

mcomella commented Jul 9, 2019 •

edited

Loading

mcomella commented Jul 9, 2019 •

edited

Loading