Skip to content
This repository has been archived by the owner on Apr 17, 2021. It is now read-only.

[DO NOT MERGE] mcomella PR to test TC fixes! #2459

Closed
wants to merge 0 commits into from

Conversation

mcomella
Copy link
Contributor

Pull Request checklist

  • This PR includes thorough tests or an explanation of why it does not
  • This PR includes a CHANGELOG entry or does not need one
  • I have considered adding QA labels on the associated issue (not this PR; qa-ready or qa-denied)

@mcomella mcomella changed the title [DO NOT MERGE] TC fix test: revert v3.10 dependency upgrades (without a-c) [DO NOT MERGE] mcomella PR to test TC fixes Jun 25, 2019
@mcomella
Copy link
Contributor Author

mcomella commented Jun 25, 2019

Things to try (each of these will be done independent from one another):

  • Revert commits in v3.10 to upgrade gradle & app/build dependencies (except for a-c)
  • Talk with TC team to see if they changed anything that could affect this: nope

N.B.: Daniela has explored many solutions already in #2431.

@codecov-io
Copy link

codecov-io commented Jun 25, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@eef55eb). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2459   +/-   ##
=========================================
  Coverage          ?   34.95%           
  Complexity        ?      299           
=========================================
  Files             ?      111           
  Lines             ?     3141           
  Branches          ?      418           
=========================================
  Hits              ?     1098           
  Misses            ?     1953           
  Partials          ?       90

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eef55eb...00feb00. Read the comment docs.

@mcomella mcomella changed the title [DO NOT MERGE] mcomella PR to test TC fixes [DO NOT MERGE] mcomella PR to test TC fixes! Jul 2, 2019
@mcomella mcomella changed the title [DO NOT MERGE] mcomella PR to test TC fixes! [DO NOT MERGE] mcomella PR to test TC fixes!! Jul 2, 2019
@mcomella mcomella changed the title [DO NOT MERGE] mcomella PR to test TC fixes!! [DO NOT MERGE] mcomella PR to test TC fixes!!! Jul 2, 2019
@mcomella mcomella changed the title [DO NOT MERGE] mcomella PR to test TC fixes!!! [DO NOT MERGE] mcomella PR to test TC fixes!!!! Jul 3, 2019
@mcomella
Copy link
Contributor Author

mcomella commented Jul 3, 2019

This has already passed 3 times today (first three exclamation points).

@dnarcese
Copy link
Contributor

dnarcese commented Jul 3, 2019

Fourth retry for backing out the dependency upgrade timed out on testGeckoDebugUnitTest

@mcomella
Copy link
Contributor Author

mcomella commented Jul 3, 2019

Hey, stop working!

@mcomella
Copy link
Contributor Author

mcomella commented Jul 3, 2019

I pushed git tag v3.3: let's see if a really old revision will trigger the failures.

@mcomella
Copy link
Contributor Author

mcomella commented Jul 3, 2019

It's also possible the a-c upgrade I made with the other dependency upgrades caused the intermittent.

@dnarcese
Copy link
Contributor

dnarcese commented Jul 3, 2019

Wow 8 minutes! It used to be so fast

@mcomella
Copy link
Contributor Author

mcomella commented Jul 3, 2019

Wow 8 minutes! It used to be so fast

Yeah, wow. I'm going to comment in the unexpectedly slow builds bug: #2463 This will be easy to retrigger!

Also, stop working!

@mcomella mcomella changed the title [DO NOT MERGE] mcomella PR to test TC fixes!!!! [DO NOT MERGE] mcomella PR to test TC fixes!!!!! Jul 3, 2019
@mcomella mcomella changed the title [DO NOT MERGE] mcomella PR to test TC fixes!!!!! [DO NOT MERGE] mcomella PR to test TC fixes!!!!!! Jul 3, 2019
@mcomella mcomella changed the title [DO NOT MERGE] mcomella PR to test TC fixes!!!!!! [DO NOT MERGE] mcomella PR to test TC fixes!!!!!!! Jul 3, 2019
@mcomella mcomella changed the title [DO NOT MERGE] mcomella PR to test TC fixes!!!!!!! [DO NOT MERGE] mcomella PR to test TC fixes!!!!!!!! Jul 3, 2019
@mcomella mcomella changed the title [DO NOT MERGE] mcomella PR to test TC fixes!!!!!!!! [DO NOT MERGE] mcomella PR to test TC fixes!!!!!!!!! Jul 3, 2019
@mcomella
Copy link
Contributor Author

mcomella commented Jul 3, 2019

6 passes and no failures on v3.3. Let's try v3.9.

@mcomella mcomella changed the title [DO NOT MERGE] mcomella PR to test TC fixes!!!!!!!!! [DO NOT MERGE] mcomella PR to test TC fixes! Jul 3, 2019
@mcomella
Copy link
Contributor Author

mcomella commented Jul 3, 2019

v3.9 success count: 5

@mcomella mcomella changed the title [DO NOT MERGE] mcomella PR to test TC fixes! [DO NOT MERGE] mcomella PR to test TC fixes!! Jul 3, 2019
@mcomella mcomella changed the title [DO NOT MERGE] mcomella PR to test TC fixes!! [DO NOT MERGE] mcomella PR to test TC fixes!!! Jul 3, 2019
@mcomella mcomella changed the title [DO NOT MERGE] mcomella PR to test TC fixes!!! [DO NOT MERGE] mcomella PR to test TC fixes!!!! Jul 3, 2019
@mcomella
Copy link
Contributor Author

mcomella commented Jul 3, 2019

Pushing v3.10. Success count: 4? 5? (caveat: 1 TC failed but with failed UI tests)

@mcomella mcomella changed the title [DO NOT MERGE] mcomella PR to test TC fixes!!!! [DO NOT MERGE] mcomella PR to test TC fixes!!!!! Jul 3, 2019
@mcomella mcomella changed the title [DO NOT MERGE] mcomella PR to test TC fixes!!!!! [DO NOT MERGE] mcomella PR to test TC fixes!!!!!! Jul 3, 2019
@mcomella mcomella changed the title [DO NOT MERGE] mcomella PR to test TC fixes!!!!!! [DO NOT MERGE] mcomella PR to test TC fixes!!!!!!! Jul 3, 2019
@mcomella mcomella changed the title [DO NOT MERGE] mcomella PR to test TC fixes!!!!!!! [DO NOT MERGE] mcomella PR to test TC fixes!!!!!!!! Jul 3, 2019
@mcomella
Copy link
Contributor Author

mcomella commented Jul 8, 2019

Just pushed v3.11: let's see how it goes. Success count: 2, 1 failure.

@mcomella mcomella changed the title [DO NOT MERGE] mcomella PR to test TC fixes!!!!!!!! [DO NOT MERGE] mcomella PR to test TC fixes Jul 8, 2019
@mcomella mcomella changed the title [DO NOT MERGE] mcomella PR to test TC fixes [DO NOT MERGE] mcomella PR to test TC fixes! Jul 8, 2019
@mcomella
Copy link
Contributor Author

mcomella commented Jul 8, 2019

v3.11 failed but v3.10 did not: perhaps the change that broke TC is between those commits.

@mcomella
Copy link
Contributor Author

mcomella commented Jul 8, 2019

Interesting: v3.10-LAT4 (which doesn't fork from master, unlike v3.10 which diverges by two commits) is just after the first commit to master that failed: 4641e177. Let's push v3.10-LAT4 to see if we can get it to reproduce.

@mcomella mcomella closed this Jul 8, 2019
@mcomella mcomella deleted the ni-tc-revert branch July 8, 2019 22:41
@mcomella mcomella restored the ni-tc-revert branch July 8, 2019 22:48
@mcomella mcomella deleted the ni-tc-revert branch July 8, 2019 22:48
@mcomella
Copy link
Contributor Author

mcomella commented Jul 8, 2019

GitHub force closed my PR so I'm now working in #2501.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants