This repository has been archived by the owner on Nov 27, 2019. It is now read-only.
fix: Avoid JS errors from external file from normandy.cdn.mozilla.org #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, |
I'd say go ahead and add that pref to this patch |
|
Thanks! |
|
@freaktechnik thanks again for this. If you feel like it, you could also port this to web-ext :) mozilla/web-ext#406 but it's not urgent |
|
Looks like Travis is failing... Build #780 - mozilla-jetpack/jpm - Travis CI |
|
This is likely due to travis using the release Firefox version and that one no longer working with jpm. (See #468 ) |
This was referenced Aug 3, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running tests I'd see JS errors from a selfrepair.js. This change makes Firefox not download that file.