Skip to content
This repository has been archived by the owner on Nov 27, 2019. It is now read-only.

Fix travis builds not being able to install unsigned extensions #562

Closed
freaktechnik opened this issue Aug 3, 2016 · 6 comments
Closed

Comments

@freaktechnik
Copy link
Contributor

freaktechnik commented Aug 3, 2016

There are four solutions to this:

  • Use the latest ESR (I think this will work until the next major ESR version)
  • Specify that we want to test against Firefox 47.0
  • Use a tool to download an unbranded build or dev-edition/nightly (dev-edition and nightly are easier afaik)
  • Fix jpm run: do temporary extension install #468

Thanks @asamuzaK for pointing the build failures of the merge of #561 out.

@freaktechnik freaktechnik changed the title Fix travis builds not being able to isntall unsigned extensions Fix travis builds not being able to install unsigned extensions Aug 3, 2016
@kumar303
Copy link
Contributor

kumar303 commented Aug 3, 2016

Hmm, I don't see explicit support from TravisCI for nightly or dev-edition. ESR gets updated infrequently so it may not be a good candidate.

We used to have code that manually downloaded and installed a firefox binary so it shouldn't be too hard to resurrect that and point it at an unbranded build.

@k88hudson
Copy link

Hey there, we noticed this yesterday on mozilla/activity-stream. For now we've decided to target nightly for local dev and stick to an earlier release of Firefox for CI, but I've been looking into other possible solutions.

Any possibility jpm run/test could be updated to use the installTemporaryAddon strategy in about:debugging? Not sure how much if it would work/is feasible, just wondering

@kumar303
Copy link
Contributor

kumar303 commented Aug 5, 2016

hi @k88hudson, I offered my idea for how to make jpm use the installTemporaryAddon strategy here: #468 (comment) I think it's just a matter of extracting the web-ext code into a new lib and shaving some yaks.

Also, to avoid confusion, the issue in this thread is about jpm's internal test suite, not the jpm test command.

@k88hudson
Copy link

@kumar303 ok, thanks!

@kumar303
Copy link
Contributor

I switched to using Nightly in CI (#568) but I think it would be nicer to use an unbranded release build. The release build will be more stable and is a more likely candidate for what jpm developers will use.

@freaktechnik did you want to try using your get-firefox script to get unbranded builds? I will leave this issue open if that's the case.

@freaktechnik
Copy link
Contributor Author

I use get-firefox in my personal travis runs, so it shouldn't be too hard.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants