-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release 30-05-2023] Android & iOS Stability Changes, Spec Implementations & Exception Handling #61
Conversation
…ilt library functions This will make the code less error prone and simplify spec writing
…string to make it consistent
…ier" This reverts commit 9d3ad26.
Release/0.3.x
…moved unused code
Signed-off-by: Alka Prasad <prasadalka1998@gmail.com>
… exception handler
…apping it with unknown
…d-missing-files Add exception handling to android missing files
…og for logging exception
Add error code to OnError Event
reason: - if a preferential PHY is not requested in a connection, the BLE 5.0 chips which have issues with 2M PHY can also connect using older PHY and the responsibility of choosing a PHY is left to the firmware/OS and other entities concerns on speed: mosip#52 Link: https://mosip.atlassian.net/browse/INJI-39 Co-authored-by: Alka Prasad <prasadalka1998@gmail.com>
…on-ios feat(mosip#71): [Tilak] Remove duplicate error handler from ios
…on-ios feat(71): [Pooja|Tilak] fix syntax error in errorHandler
fix(INJI-39): skip request for PHY upgrade to PHY2 [ Develop ]
Signed-off-by: vijay151096 <94220135+vijay151096@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good to me
Enhancements:
mosip/inji-wallet#696 - Verify Inji build on windows machine
Spec Implementation :
#39 - update format of ResponseSize Characteristics
#42 - move all byte buffer to big endian/network byte order format
#43 - [Spec Impl] Change Tuvali's VC chunk counter sequence number from 0 based to 1
Documentation :
mosip/inji-wallet#413 - Document BLE design and technical specification
Exception Handling :
#38 - [IOS] Research and safely handle Uncaught exceptions in IOS Tuvali
mosip/inji-wallet#702 - [Android]Add exception handling for missing files in Tuvali
mosip/inji-wallet#695 - Display Error code when Tuvali transfer fails
INJI-52 - Add exception handling for missing files in Tuvali
INJI-71 - [IOS & Android] Pass error codes on Error