Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release 30-05-2023] Android & iOS Stability Changes, Spec Implementations & Exception Handling #61

Merged
merged 73 commits into from
May 30, 2023

Conversation

vijay151096
Copy link
Contributor

@vijay151096 vijay151096 commented May 30, 2023

Enhancements:

mosip/inji-wallet#696 - Verify Inji build on windows machine

Spec Implementation :

#39 - update format of ResponseSize Characteristics
#42 - move all byte buffer to big endian/network byte order format
#43 - [Spec Impl] Change Tuvali's VC chunk counter sequence number from 0 based to 1

Documentation :

mosip/inji-wallet#413 - Document BLE design and technical specification

Exception Handling :

#38 - [IOS] Research and safely handle Uncaught exceptions in IOS Tuvali
mosip/inji-wallet#702 - [Android]Add exception handling for missing files in Tuvali
mosip/inji-wallet#695 - Display Error code when Tuvali transfer fails
INJI-52 - Add exception handling for missing files in Tuvali
INJI-71 - [IOS & Android] Pass error codes on Error

Alka1703 and others added 30 commits March 17, 2023 18:35
…ilt library functions

This will make the code less error prone and simplify spec writing
Signed-off-by: Alka Prasad <prasadalka1998@gmail.com>
krishnakumar4a4 and others added 23 commits April 17, 2023 16:43
…d-missing-files

Add exception handling to android missing files
Add error code to OnError Event
reason:

- if a preferential PHY is not requested in a connection, the BLE 5.0
  chips which have issues with 2M PHY can also connect using older
  PHY and the responsibility of choosing a PHY is left to the
  firmware/OS and other entities

concerns on speed: mosip#52

Link: https://mosip.atlassian.net/browse/INJI-39

Co-authored-by: Alka Prasad <prasadalka1998@gmail.com>
…on-ios

feat(mosip#71): [Tilak] Remove duplicate error handler from ios
…on-ios

feat(71): [Pooja|Tilak] fix syntax error in errorHandler
fix(INJI-39): skip request for PHY upgrade to PHY2 [ Develop ]
Signed-off-by: vijay151096 <94220135+vijay151096@users.noreply.github.com>
@vharsh vharsh requested review from vharsh and krishnakumar4a4 May 30, 2023 06:49
Copy link
Member

@vharsh vharsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@vharsh vharsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vijay151096 vijay151096 changed the title [Release 19-05-2023] Android & iOS Stability Changes, Spec Implementations & Exception Handling [Release 30-05-2023] Android & iOS Stability Changes, Spec Implementations & Exception Handling May 30, 2023
Copy link
Contributor

@krishnakumar4a4 krishnakumar4a4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to me

@vharsh vharsh merged commit 0955769 into mosip:master May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants