Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enum migration for Postgres #327

Merged
merged 3 commits into from
Jun 21, 2017
Merged

Fix enum migration for Postgres #327

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d1d317
Fix postgres migration.
Jun 16, 2017
345bf08
Add driver name to thrown exception in migration.
Jun 17, 2017
c8b478f
Merge branch 'master' into master
djaiss Jun 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 35 additions & 3 deletions database/migrations/2017_06_07_173437_add_multiple_genders_choices.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,40 @@ class AddMultipleGendersChoices extends Migration
*/
public function up()
{
DB::statement("ALTER TABLE contacts CHANGE COLUMN gender gender ENUM('male', 'female', 'none')");
DB::statement("ALTER TABLE significant_others CHANGE COLUMN gender gender ENUM('male', 'female', 'none')");
DB::statement("ALTER TABLE kids CHANGE COLUMN gender gender ENUM('male', 'female', 'none')");
switch(DB::connection()->getPDO()->getAttribute(PDO::ATTR_DRIVER_NAME))
{
case 'mysql':
DB::statement("ALTER TABLE contacts CHANGE COLUMN gender gender ENUM('male', 'female', 'none')");
DB::statement("ALTER TABLE significant_others CHANGE COLUMN gender gender ENUM('male', 'female', 'none')");
DB::statement("ALTER TABLE kids CHANGE COLUMN gender gender ENUM('male', 'female', 'none')");
break;
case 'pgsql':
$this->alterEnum('contacts', 'gender', ['male', 'female', 'none']);
$this->alterEnum('significant_others', 'gender', ['male', 'female', 'none']);
$this->alterEnum('kids', 'gender', ['male', 'female', 'none']);
break;
default:
throw new \Exception('Driver not supported.');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you put the driver name in this string, please?

It is easier to help someone with a message Driver foobar is not supported.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

break;
}
}

/**
* Alter an enum field constraints. Source: https://stackoverflow.com/a/36198549
* @param $table
* @param $field
* @param array $options
*/
protected function alterEnum($table, $field, array $options) {
$check = "${table}_${field}_check";
$enumList = [];
foreach($options as $option) {
$enumList[] = sprintf("'%s'::CHARACTER VARYING", $option);
}
$enumString = implode(", ", $enumList);
DB::transaction(function () use ($table, $field, $check, $options, $enumString) {
DB::statement(sprintf('ALTER TABLE %s DROP CONSTRAINT %s;', $table, $check));
DB::statement(sprintf('ALTER TABLE %s ADD CONSTRAINT %s CHECK (%s::TEXT = ANY (ARRAY[%s]::TEXT[]))', $table, $check, $field, $enumString));
});
}
}