Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enum migration for Postgres #327

Merged
merged 3 commits into from
Jun 21, 2017
Merged

Fix enum migration for Postgres #327

merged 3 commits into from
Jun 21, 2017

Conversation

supergillis
Copy link

@supergillis supergillis commented Jun 16, 2017

Fixes enum migration in issue #137

@supergillis supergillis changed the title Fix migration for Postgres #137 Fix migration for Postgres Jun 16, 2017
@supergillis supergillis changed the title Fix migration for Postgres Fix enum migration for Postgres Jun 16, 2017
$this->alterEnum('kids', 'gender', ['male', 'female', 'none']);
break;
default:
throw new \Exception('Driver not supported.');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you put the driver name in this string, please?

It is easier to help someone with a message Driver foobar is not supported.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@djaiss
Copy link
Member

djaiss commented Jun 21, 2017

Thanks a lot for this PR!

@djaiss djaiss merged commit a1d8c52 into monicahq:master Jun 21, 2017
@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants