Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to upload photos #2132

Merged
merged 10 commits into from
Dec 13, 2018
Merged

feat: add ability to upload photos #2132

merged 10 commits into from
Dec 13, 2018

Conversation

djaiss
Copy link
Member

@djaiss djaiss commented Dec 4, 2018

This PR adds photo upload capabilities to a contact. It's a fork of the PR #2112 that was too big.

@asbiin I haven't done the API methods for this, like I did for documents. I don't think we should allow the upload of files through the API for now (simply because... I don't know how to deal with uploads through an API) 😀

What has been done:

  • add a new tab under the profile of a contact, called photos
  • this tab is empty by default
  • you can upload photos if your account allows you to
  • there is the same upload mechanism that the one used on the documents
  • the Storage tab under Settings has been updated to include the photos now
  • the global method that checks if the user is above its account storage limit has also been updated.

@djaiss djaiss requested a review from asbiin December 4, 2018 23:49
Copy link

@sonarqubecloud sonarqubecloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 2

See all issues in SonarCloud

@asbiin
Copy link
Member

asbiin commented Dec 5, 2018

OK, for the API part we can do this later then.

@djaiss
Copy link
Member Author

djaiss commented Dec 5, 2018

@asbiin just updated the description at the top to indicate what has been done in this PR.

@djaiss djaiss merged commit 64a7e51 into master Dec 13, 2018
@djaiss djaiss deleted the 2018-12-04-photo-upload branch December 19, 2018 00:25
@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants