-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change avatar management #2112
Conversation
…nto 2018-11-17-new-avatars
…nto 2018-11-17-new-avatars
…nto 2018-11-17-new-avatars
…nto 2018-11-17-new-avatars
Oh, it's been merged already. Guess not? |
@scott-joe the problem is still there, but as there are now 1 avatar file per contact, you can't see it. Your solution is nice, I will fix it as soon as possible. |
Cool! Happy to help :) I'd love to get the thing running locally to help. Just gotta find some free time :P |
It took me some digging to find this issue so I could migrate my avatars after updating monica (from v2.14). Is there a way to get this built into the main |
This pull request has been automatically locked since there |
This PR completely changes how avatars are managed.
This close #2032
This close #2145
This close #715
This close #702
This close #703
Note:⚠️ after migrating data, you need to run
php artisan monica:moveavatarstophotosdirectory
to move all the current avatars to the new Photo directory, as avatars are now actually Photo objects.There are several things to do in another PR once we merge this PR:
gravatar_url
,avatar_location
,avatar_file_name
,avatar_external_url
,has_avatar
from the DB, which will be not used anymore. We first need to migrate all avatars to remove them completely, so it's better to do it in another PR.Tasks remaining to be done
vCard
and.csv
files.updateGravatar()
gravatar_url
,avatar_location
,avatar_file_name
,avatar_external_url
,has_avatar
propertiesUNRELEASED
.