This repository has been archived by the owner on Jun 8, 2023. It is now read-only.
fix: fix sortByCollator collection macro return keys
#556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents results from being conformed to an object via Inertia rendering
|
Side-note, is there desire for an E2E testing suite using something like Laravel Dusk? I have some experience setting up CI for that and could contribute in that way! |
sortByCollator collection macro return keyssortByCollator collection macro return keys
We don't have such E2E testing for the moment. That would be lovely if want to contribute for that. We also used to start using cypress in the Monica project, but I'm open to any good suggestion! |
asbiin
pushed a commit
to monicahq/monica
that referenced
this pull request
Jun 3, 2023
…dler#556) Fix to `sortByCollator` collection macro Prevents results from being conformed to an object via Inertia rendering
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents results from being conformed to an object via Inertia rendering where an array is expected.
I observed a bug where entities from different account personalization sections weren't rendering because the frontend Vue code was expecting an array of entity DTO objects but got a nested object of entity DTO objects which broke frontend logic depending on the presence of an array.
Believe this issue may have been introduced with the addition of the localization collection sorting macro and traced it to the construction of the new collection. Looks like all that needed to be done was clean the keys after sorting to prevent Inertia from rendering as a JS object rather than an array.