Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Mongoid 9 #83

Merged
merged 4 commits into from
Nov 19, 2024
Merged

Add support for Mongoid 9 #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ae33bef
Add support for Mongoid 9
asgerb Nov 18, 2024
d8dbf99
Update CHANGELOG.md
asgerb Nov 19, 2024
e70a51a
Update CHANGELOG.md
dblock Nov 19, 2024
82e43b9
Add matrix entries for mongodb 4, 5, and 6
asgerb Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,15 @@ jobs:
- { ruby: '3.0', mongodb: '4.4', gemfile: 'mongoid-8.0' }
- { ruby: '3.1', mongodb: '4.4', gemfile: 'mongoid-8.0' }
- { ruby: '3.2', mongodb: '4.4', gemfile: 'mongoid-8.0' }
- { ruby: '3.1', mongodb: '4', gemfile: 'mongoid-9.0' }
- { ruby: '3.1', mongodb: '5', gemfile: 'mongoid-9.0' }
- { ruby: '3.1', mongodb: '6', gemfile: 'mongoid-9.0' }
- { ruby: '3.2', mongodb: '4', gemfile: 'mongoid-9.0' }
- { ruby: '3.2', mongodb: '5', gemfile: 'mongoid-9.0' }
- { ruby: '3.2', mongodb: '6', gemfile: 'mongoid-9.0' }
- { ruby: '3.3', mongodb: '4', gemfile: 'mongoid-9.0' }
- { ruby: '3.3', mongodb: '5', gemfile: 'mongoid-9.0' }
- { ruby: '3.3', mongodb: '6', gemfile: 'mongoid-9.0' }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but we don't really need to test every combination of Ruby and MongoDB and mongoid. I would only keep latest 2.x and 3.x, but it's NBD.

name: test (ruby=${{ matrix.entry.ruby }}, mongodb=${{ matrix.entry.mongodb }}), gemfile=${{ matrix.entry.gemfile }})
env:
BUNDLE_GEMFILE: gemfiles/${{ matrix.entry.gemfile }}.gemfile
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
### Unreleased - TBD

* [#83](https://github.com/mongoid/mongoid-grid_fs/pull/83): Add support for Mongoid 9 - [@asgerb](https://github.com/asgerb).
* Your contribution here.

### 2.5.0 (2023/01/19)
Expand Down
6 changes: 6 additions & 0 deletions gemfiles/mongoid-9.0.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
source 'https://rubygems.org'

gem 'mongoid', '~> 9.0.0'
gem 'rails', '~> 7.0'

gemspec path: '../'
2 changes: 1 addition & 1 deletion mongoid-grid_fs.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,5 @@ Gem::Specification.new do |spec|
spec.add_development_dependency 'rubocop', '~> 1.36.0'

spec.add_dependency 'mime-types', '>= 1.0', '< 4.0'
spec.add_dependency 'mongoid', '>= 3.0', '< 9.0'
spec.add_dependency 'mongoid', '>= 3.0', '< 10.0'
end
Loading