Add support for Mongoid 9 #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
reviewed
Nov 19, 2024
Generated by 🚫 Danger |
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@dblock.org>
dblock
reviewed
Nov 19, 2024
dblock
requested changes
Nov 19, 2024
|
@dblock I've started just with the matrix entries added in this PR, if needed I can make another PR for the rest of the matrix |
dblock
reviewed
Nov 19, 2024
| - { ruby: '3.2', mongodb: '6', gemfile: 'mongoid-9.0' } | ||
| - { ruby: '3.3', mongodb: '4', gemfile: 'mongoid-9.0' } | ||
| - { ruby: '3.3', mongodb: '5', gemfile: 'mongoid-9.0' } | ||
| - { ruby: '3.3', mongodb: '6', gemfile: 'mongoid-9.0' } |
There was a problem hiding this comment.
This is fine, but we don't really need to test every combination of Ruby and MongoDB and mongoid. I would only keep latest 2.x and 3.x, but it's NBD.
Closed
|
I released 2.6.0. If you want to do some more cleanup, upgrades like RuboCop, etc., that would be much welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Mongoid 9