Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Make newPivotQuery function public #1979

Merged
merged 2 commits into from
Mar 4, 2020
Merged

[fix] Make newPivotQuery function public #1979

merged 2 commits into from
Mar 4, 2020

Conversation

divine
Copy link
Contributor

@divine divine commented Mar 3, 2020

This is an urgent change, probably we need to release new version 3.6.3 as soon as possible.

PR laravel/framework#31677 changed newPivotQuery function from protected to public and that's the reason why builds are failing.

PHP Fatal error: Access level to Jenssegers\Mongodb\Relations\BelongsToMany::newPivotQuery() must be public (as in class Illuminate\Database\Eloquent\Relations\BelongsToMany) in /home/runner/work/laravel-mongodb/laravel-mongodb/src/Jenssegers/Mongodb/Relations/BelongsToMany.php on line 268

@divine
Make newPivotQuery function public
dfdcfc5 
PR laravel/framework#31677 made newPivotQuery function public and that's the reason why builds are failing.
@divine divine requested a review from Smolevich March 3, 2020 15:59
@divine
Change laravel version to 6.x
27acb90 
Laravel versions starting from 6 are all  6.x
@darcyrailip
Copy link

Would be great to get this out ASAP!

@benpoulson
Copy link

Can confirm this fixes a few issues I've been encountering.

@Smolevich Smolevich merged commit 279b18c into mongodb:master Mar 4, 2020
@divine divine deleted the fix_make_pivot_public branch March 4, 2020 07:59
@divine
Copy link
Contributor Author

divine commented Mar 5, 2020

See #1978

@mongodb mongodb locked as resolved and limited conversation to collaborators Mar 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Smolevich Smolevich Smolevich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@divine @darcyrailip @benpoulson @Smolevich @elenabakun-hyuna