Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Laravel 7 #1978

Closed
wants to merge 2 commits into from
Closed

Allow Laravel 7 #1978

wants to merge 2 commits into from

Conversation

filipac
Copy link
Contributor

@filipac filipac commented Mar 3, 2020

This was released just now.

@filipac
Allow Laravel 7
4ae5d99 
This was released just now.
@filipac
Copy link
Contributor Author

filipac commented Mar 3, 2020

Hmm guess we have a breaking change:

PHP Fatal error:  Access level to Jenssegers\Mongodb\Relations\BelongsToMany::newPivotQuery() must be public (as in class Illuminate\Database\Eloquent\Relations\BelongsToMany) in /home/runner/work/laravel-mongodb/laravel-mongodb/src/Jenssegers/Mongodb/Relations/BelongsToMany.php on line 268

@Smolevich
Copy link
Contributor

@filipac, we plan to support new version not immediately, we want to show on new features and bugs, so supporting new version will be soon in version 4 of this library

@Smolevich
Copy link
Contributor

@divine already works on this task

@Smolevich Smolevich closed this Mar 3, 2020
@filipac
Copy link
Contributor Author

filipac commented Mar 3, 2020

@Smolevich got it :) I created the branch to check if it works locally with L7 and it did :)

@Smolevich Smolevich mentioned this pull request Mar 4, 2020
Closed
@divine divine mentioned this pull request Mar 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filipac @Smolevich