Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: Updated dependencies Cmake 3.13 and CPPZMQ 4.3.0 #4890

Closed
wants to merge 73 commits into from
Closed

Docker: Updated dependencies Cmake 3.13 and CPPZMQ 4.3.0 #4890

wants to merge 73 commits into from

Conversation

homdx
Copy link
Contributor

@homdx homdx commented Nov 22, 2018

No description provided.

@moneromooo-monero
Copy link
Collaborator

Please squash the commits.

homdx and others added 29 commits November 23, 2018 00:42
  - Support for classes
  - Added `remove_prefix` function
  - Added `to_mut_span` and `as_mut_byte_span`
it's confusing and needlessly complicated
They're controllable by potential attackers and would just spam
Make it easier for a user to be told when to update
with consensus rules and block heights
This makes it easier to avoid bugs on the caller side if errors are
represented by non empty strings.

This fixes the refresh height setting in new wallets when no daemon
is running.
Rebased by moneromooo, with a sensible commit message
'outputs' option allows to specify the number of
separate outputs of smaller denomination that will
be created by sweep operation.

rebased by moneromooo
Implemented strategy splits total amount into N equal parts,
where N is a specified number of outputs. If N > 1, dummy
change output is NOT created.

rebased by moneromooo
Thanks iDunk for building patches on windows
fluffypony and others added 25 commits November 23, 2018 00:45
7964d4f wallet2: handle corner case in picking fake outputs (moneromooo-monero)
43a0635 ringdb: use cursors to be a bit faster (moneromooo-monero)
7a056f4 WalletAPI: multisigSignData bug fixed (naughtyfox)
a21da90 Wallet: use unique_ptr for WalletImpl members (oneiric)
92d1da2 unit_tests: fix build with GCC 5.4.0 on ubuntu (moneromooo-monero)
a69271f Fixed a typo (Piotr Kąkol)
83debef wallet_rpc_server: remove verbose field in incoming_transfers query (moneromooo-monero)
8928886 README: mention ASAN usage alongside valgrind (moneromooo-monero)
174f31b simplewallet: don't complain about payment id on pool mined blocks (moneromooo-monero)
b297292 osx compilation fix: missing boost libs added (Dusan Klinec)
fe12564 Fixup RENAME_DB() macro (Howard Chu)
69da14e fixes make debug compilation on OSX (Dusan Klinec)
6a78140 Make depends use self built clang for darwin (TheCharlatan)
17142ec malloc scratchpad for all supported android archs (m2049r)
06d05c2 device: set device name correctly if key_on_device is set (Dusan Klinec)
85318e7 build: set ARCH_FLAG before compiler/linker flag checks (xiphon)
921b0fb use default create_address_file argument (m2049r)
bcf3f6a fuzz_tests: catch unhandled exceptions (moneromooo-monero)
3ebd05d miner: restore stream flags after changing them (moneromooo-monero)
a093092 levin_protocol_handler_async: do not propagate exception through dtor (moneromooo-monero)
1eebb82 net_helper: do not propagate exceptions through dtor (moneromooo-monero)
fb6a363 miner: do not propagate exceptions through dtor (moneromooo-monero)
2e2139f epee: do not propagate exception through dtor (moneromooo-monero)
0749a8b db_lmdb: do not propagate exceptions in dtor (moneromooo-monero)
1b0afee wallet_rpc_server: exit cleanly on unhandled exceptions (moneromooo-monero)
418a993 unit_tests: catch unhandled exceptions (moneromooo-monero)
ea7f954 threadpool: do not propagate exceptions through the dtor (moneromooo-monero)
6e85542 gen_multisig: nice exit on unhandled exception (moneromooo-monero)
53df2de db_lmdb: catch error in mdb_stat calls during migration (moneromooo-monero)
e67016d blockchain_blackball: catch failure to commit db transaction (moneromooo-monero)
661439f mlog: don't remove old logs if we failed to rename the current file (moneromooo-monero)
5fdcda5 easylogging++: test for NULL before dereference (moneromooo-monero)
7ece155 performance_test: fix bad last argument calling add_arg (moneromooo-monero)
a085da3 unit_tests: add check for page size > 0 before dividing (moneromooo-monero)
d8b1ec8 unit_tests: use std::shared_ptr to shut coverity up about leaks (moneromooo-monero)
02563bf simplewallet: top level exception catcher to print nicer messages (moneromooo-monero)
c57a65b blockchain_blackball: fix shift range for 32 bit archs (moneromooo-monero)
7dd1171 wallet2: fix transfers between subaddresses hitting the sanity check (moneromooo-monero)
7340300 add --block-notify to monerod and --tx-notify to monero-wallet-{cli,rpc} (moneromooo-monero)
A few of them are now returning invalid replies.
@moneromooo-monero
Copy link
Collaborator

That made is worse. If you can't get git to squash properly, it might be simpler to just reset the branch, and reapply the commits since it's dozen lines.

@homdx
Copy link
Contributor Author

homdx commented Nov 22, 2018

That made is worse. If you can't get git to squash properly, it might be simpler to just reset the branch, and reapply the commits since it's dozen lines.

Replaced to
#4891

@moneromooo-monero
Copy link
Collaborator

+duplicate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.