wallet2: handle corner case in picking fake outputs #4406
Conversation
If we originally think we have enough outputs on the blockchain to pick random fake outputs, we might end up with not enough of them if enough are actually blackballed.
4e09e8f to
7964d4f
Compare
| // outputs, we still need to reach the minimum ring size) | ||
| if (allow_blackballed) | ||
| break; | ||
| MINFO("Not enough non blackballed outputs, we'll allow blackballed ones"); |
There was a problem hiding this comment.
Would it be helpful here to prompt the user if they want to continue w/ blackballed outputs? Or maybe at the end of output selection, display number of blackballed outputs used (if any)?
There was a problem hiding this comment.
If this happens, the output is only spendable if it uses blackballed outputs, so it'd be giving the user a choice of using or losing the monero.
There was a problem hiding this comment.
Ok, I misunderstood then. Thought the user could stop, and retry again when there might be more non-blackballed outputs available.
I can think of scenarios where losing it might be better than using with reduced privacy, the opposite is obvious.
There was a problem hiding this comment.
Well, there might be other outpputs from the wallet to choose from, but as it stand retrying would most likely just select the same ones. There would need to be a patch keeping track (in the wallet) of the amount of blackballed out per amount and not picking those in the first place. That'd mean they're unpendable, but that could be made a wallet setting.
7964d4f wallet2: handle corner case in picking fake outputs (moneromooo-monero)
7964d4f wallet2: handle corner case in picking fake outputs (moneromooo-monero)
If we originally think we have enough outputs on the blockchain
to pick random fake outputs, we might end up with not enough of
them if enough are actually blackballed.