wallet-rpc: filter getbalance response by address index #4171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4c72080 to
10645fa
Compare
| @@ -62,8 +62,10 @@ namespace wallet_rpc | |||
| struct request | |||
| { | |||
| uint32_t account_index; | |||
| std::set<uint32_t> address_index; | |||
There was a problem hiding this comment.
Maybe best to call it address_indices ? Also there's a RPC version number for the wallet now too. Seemed like a good idea at the time :)
10645fa to
9127a8b
Compare
|
The RPC Also bumped the wallet RPC to 1.2. FWIW another PR #4170 bumps it to |
moneromooo-monero
approved these changes
Jul 31, 2018
luigi1111
added a commit
that referenced
this pull request
Aug 15, 2018
9127a8b wallet-rpc: filter getbalance response by address index (stoffu)
This was referenced Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.