Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet-rpc: add get_address_index command #4170

Merged
merged 1 commit into from
Aug 15, 2018

Conversation

stoffu
Copy link
Contributor

@stoffu stoffu commented Jul 23, 2018

No description provided.

Copy link
Collaborator

@moneromooo-monero moneromooo-monero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a RPC version bump too.

@stoffu stoffu force-pushed the wrpc-get-addr-idx branch from 9f69ae6 to bd12009 Compare July 31, 2018 11:28
@stoffu
Copy link
Contributor Author

stoffu commented Jul 31, 2018

OK, I've bumped the major version as I consider adding a new command as an incompatible change:

// When making *any* change here, bump minor
// If the change is incompatible, then bump major and set minor to 0

@moneromooo-monero
Copy link
Collaborator

It is compatible, as in "if you change the server, an old client still works".
If you consider adding something as incompatible, then pretty much every change is incompatible.

@stoffu stoffu force-pushed the wrpc-get-addr-idx branch from bd12009 to 1c6cfd3 Compare July 31, 2018 12:36
@stoffu
Copy link
Contributor Author

stoffu commented Jul 31, 2018

Ah, that was my misunderstanding. Changed to 1.2.

@luigi1111 luigi1111 merged commit 1c6cfd3 into monero-project:master Aug 15, 2018
luigi1111 added a commit that referenced this pull request Aug 15, 2018
1c6cfd3 wallet-rpc: add get_address_index command (stoffu)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants