For 0.12.3.0 #4092

moneromooo-monero · 2018-07-03T14:19:47Z

No description provided.

This gets rid of an innocuous race trying to add the same tx twice to the txpool

Once readline is initialized, std::cerr's operator<< will output a 0xff byte for unknown reasons.

avoids RPC thread dying, causing the wallet to timeout

…ed to std::string

Otherwise the previous daemon's trustedness would carry over. If not specified, the local address check is performed again.

when connecting the wallet to a daemon on a tor hidden service

Avoids valgrind reporting uninitialized data usage

This means monero-wallet-rpc still does, but the user level program does not.

Update readme to include pcslite dependency

…ubaddresses

a connection's timeout is halved for every extra connection from the same host. Also keep track of when we don't need to use a connection anymore, so we can close it and free the resource for another connection. Also use the longer timeout for non routable local addresses.

Demoted the 3rd party maintained package installs to after compiling from repository source and removed the broken Homebrew package instructions.

…ardware

anonimal · 2018-07-03T20:42:03Z

@fluffypony I really really really really hope that #3990 is resolved before we bump to 0.12.3.0. I can't update dependencies until that happens.

stoffu · 2018-07-04T02:02:06Z

I got these compile errors when I pass -DBUILD_GUI_DEPS=ON to cmake:

src/wallet/api/wallet.cpp:600:9: error: use of undeclared identifier 'setStatusError'
        setStatusError(string(tr("failed to generate new wallet: ")) + e.what());

src/wallet/api/wallet_manager.cpp:128:29: error: no member named 'parse_subaddress_lookahead' in namespace 'tools'
    auto lookahead = tools::parse_subaddress_lookahead(subaddressLookahead);
                     ~~~~~~~^

due to #3489 and #3921 (only 248310d, the other two are already in) not being merged to the release-0.12 branch.

This would cause crashes when trying to tag an account that was just created

use snprintf "just in case" where appropriate consistently use unsigned for temp values pass std::string by const ref rather than by value add length check (which can't happen in practice) for memcpy

moneromooo-monero · 2018-07-04T09:49:17Z

Fixed.

…h this, and other, errors in the future.

anonimal

Will you include #3999?

moneromooo-monero · 2018-07-04T21:07:19Z

I wasn't planning to. I could certainly be convinced to.

anonimal · 2018-07-04T21:38:01Z

/me puts on convincing hat

moneromooo-monero · 2018-07-04T21:53:44Z

I've asked pony/luigi what they think.

fluffypony

Reviewed

3a1ad04 docker: update to new versions of dependencies (HomDx) fc8726f fix sha256sum check, which requires two spaces. added set -ex to catch this, and other, errors in the future. (cornfeedhobo) 8c331a6 wallet2: fix double counting outs if the tx pubkey is duplicated (moneromooo-monero) 2daf54d abstract_tcp_server2: fix use after free (moneromooo-monero) 41662eb device_ledger: fix buffer underflow on bad data from device (moneromooo-monero) e389101 device: misc cleanup (moneromooo-monero) 076b7e1 device_ledger: fix potential buffer overflow from bad size calc (moneromooo-monero) 0429cab simplewallet: init trusted daemon flag to false when autodetecting (moneromooo-monero) b323d90 wallet2: fix read buffer overflow in import_key_images (moneromooo-monero) 47b42f8 wallet-rpc.getaddress: throw if index is out of bound (stoffu) 223429f zmq_server: fix bind call when address and/or port are empty (moneromooo-monero) 280e1a6 Fix RPC crashes that didn't check for an open wallet (Howard Chu) 43a1249 wallet2: fix out of sync account tag cache (moneromooo-monero) e5ac16b abstract_tcp_server2: restart async accept on error (moneromooo-monero) bea06d1 epee.string_tools: add conversion between UTF-8 and UTF-16 (stoffu) e93058b wallet_api: fixups to build on the branch (moneromooo-monero) 8fb50b7 Wallet API: add support for wallet creation from hardware device (stoffu) 9e9cd10 Move parse_subaddress_lookahead() from simplewallet.cpp to util.cpp (stoffu) fbdc309 wallet2: lower default for subaddress lookahead when restoring with hardware (stoffu) ed366ef add disclaimer about 3rd party packages (Jethro Grassie) afa6696 wallet: allow unspendable unmixable outputs to be discarded (stoffu) e70d80e wallet2: use decoded amount when reporting repeated output key (stoffu) 5e180c7 wallet2: use correct fee for split txes (stoffu) d099dba epee: adaptive connection timeout system (moneromooo-monero) 04abe99 simplewallet: don't confirm missing payment ID when sending to only subaddresses (stoffu) 9c2f09d epee: fallback to a counter if gmtime fails when rotating logs (moneromooo-monero) 505fde2 Update readme to include pcslite dependency (Gingeropolous) 009feac wallet2: fix get_approximate_blockchain_height for stagenet (stoffu) 7ce841c wallet: do not log by default if we're not asked to log to console (moneromooo-monero) 4e2b279 tx_pool: initialize bitflags padding since it gets written to storage (moneromooo-monero) b85169a README: mention --untrusted-daemon (moneromooo-monero) 082e0a1 util: consider Tor/I2P addresses to be non local (moneromooo-monero) 85d2ae4 simplewallet: add optional trusted/untrusted argument to set_daemon (moneromooo-monero) 233a1ea blockchain: pop forked blocks only when DB is not read-only (stoffu) 1380b70 Fixes #3645: error on freebsd lambda return values forced to std::string (rockhouse@users.noreply.github.com) 8e64b61 blockchain: return error when requesting non existent output (moneromooo-monero) 1d3874d epee: fix detection of 172.16.0.0/172.31.255.255 local IP range (moneromooo-monero) 7400852 daemon: fix readline interfering with std::cerr usage (moneromooo-monero) 81e3926 disable file size sanity check when loading the wallet cache (moneromooo-monero) e04ae08 fix build with GCC 8.1.0 (moneromooo-monero) f6896d9 core: lock incoming tx lock when checking the txpool and chain (moneromooo-monero) f6dbb96 simplewallet: add --untrusted-daemon option (moneromooo-monero)

moneromooo-monero and others added 24 commits July 3, 2018 11:17

simplewallet: add --untrusted-daemon option

f6dbb96

core: lock incoming tx lock when checking the txpool and chain

f6896d9

This gets rid of an innocuous race trying to add the same tx twice to the txpool

fix build with GCC 8.1.0

e04ae08

disable file size sanity check when loading the wallet cache

81e3926

daemon: fix readline interfering with std::cerr usage

7400852

Once readline is initialized, std::cerr's operator<< will output a 0xff byte for unknown reasons.

epee: fix detection of 172.16.0.0/172.31.255.255 local IP range

1d3874d

blockchain: return error when requesting non existent output

8e64b61

avoids RPC thread dying, causing the wallet to timeout

Fixes monero-project#3645: error on freebsd lambda return values forc…

1380b70

…ed to std::string

blockchain: pop forked blocks only when DB is not read-only

233a1ea

simplewallet: add optional trusted/untrusted argument to set_daemon

85d2ae4

Otherwise the previous daemon's trustedness would carry over. If not specified, the local address check is performed again.

util: consider Tor/I2P addresses to be non local

082e0a1

README: mention --untrusted-daemon

b85169a

when connecting the wallet to a daemon on a tor hidden service

tx_pool: initialize bitflags padding since it gets written to storage

4e2b279

Avoids valgrind reporting uninitialized data usage

wallet: do not log by default if we're not asked to log to console

7ce841c

This means monero-wallet-rpc still does, but the user level program does not.

wallet2: fix get_approximate_blockchain_height for stagenet

009feac

Update readme to include pcslite dependency

505fde2

Update readme to include pcslite dependency

epee: fallback to a counter if gmtime fails when rotating logs

9c2f09d

simplewallet: don't confirm missing payment ID when sending to only s…

04abe99

…ubaddresses

wallet2: use correct fee for split txes

5e180c7

wallet2: use decoded amount when reporting repeated output key

e70d80e

wallet: allow unspendable unmixable outputs to be discarded

afa6696

add disclaimer about 3rd party packages

ed366ef

Demoted the 3rd party maintained package installs to after compiling from repository source and removed the broken Homebrew package instructions.

wallet2: lower default for subaddress lookahead when restoring with h…

fbdc309

…ardware

stoffu and others added 4 commits July 4, 2018 10:40

Move parse_subaddress_lookahead() from simplewallet.cpp to util.cpp

9e9cd10

Wallet API: add support for wallet creation from hardware device

8fb50b7

wallet_api: fixups to build on the branch

e93058b

epee.string_tools: add conversion between UTF-8 and UTF-16

bea06d1

moneromooo-monero and others added 12 commits July 4, 2018 10:40

abstract_tcp_server2: restart async accept on error

e5ac16b

wallet2: fix out of sync account tag cache

43a1249

This would cause crashes when trying to tag an account that was just created

Fix RPC crashes that didn't check for an open wallet

280e1a6

zmq_server: fix bind call when address and/or port are empty

223429f

wallet-rpc.getaddress: throw if index is out of bound

47b42f8

wallet2: fix read buffer overflow in import_key_images

b323d90

simplewallet: init trusted daemon flag to false when autodetecting

0429cab

device_ledger: fix potential buffer overflow from bad size calc

076b7e1

device: misc cleanup

e389101

use snprintf "just in case" where appropriate consistently use unsigned for temp values pass std::string by const ref rather than by value add length check (which can't happen in practice) for memcpy

device_ledger: fix buffer underflow on bad data from device

41662eb

abstract_tcp_server2: fix use after free

2daf54d

wallet2: fix double counting outs if the tx pubkey is duplicated

8c331a6

moneromooo-monero force-pushed the for-0.12.3.0 branch from cf3f91c to 8c331a6 Compare July 4, 2018 09:41

cornfeedhobo and others added 2 commits July 4, 2018 14:42

fix sha256sum check, which requires two spaces. added set -ex to catc…

fc8726f

…h this, and other, errors in the future.

docker: update to new versions of dependencies

3a1ad04

stoffu approved these changes Jul 4, 2018

View reviewed changes

anonimal reviewed Jul 4, 2018

View reviewed changes

fluffypony approved these changes Jul 5, 2018

View reviewed changes

fluffypony merged commit 3a1ad04 into monero-project:release-v0.12 Jul 5, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

For 0.12.3.0 #4092

For 0.12.3.0 #4092

moneromooo-monero commented Jul 3, 2018

anonimal commented Jul 3, 2018

stoffu commented Jul 4, 2018 •

edited

Loading

moneromooo-monero commented Jul 4, 2018

anonimal left a comment

moneromooo-monero commented Jul 4, 2018

anonimal commented Jul 4, 2018

moneromooo-monero commented Jul 4, 2018

fluffypony left a comment

For 0.12.3.0 #4092

For 0.12.3.0 #4092

Conversation

moneromooo-monero commented Jul 3, 2018

anonimal commented Jul 3, 2018

stoffu commented Jul 4, 2018 • edited Loading

moneromooo-monero commented Jul 4, 2018

anonimal left a comment

Choose a reason for hiding this comment

moneromooo-monero commented Jul 4, 2018

anonimal commented Jul 4, 2018

moneromooo-monero commented Jul 4, 2018

fluffypony left a comment

Choose a reason for hiding this comment

stoffu commented Jul 4, 2018 •

edited

Loading