Wallet API: add support for wallet creation from hardware device #3921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cslashm
reviewed
Jun 4, 2018
|
@cslashm |
src/wallet/api/wallet_manager.cpp
Outdated
| auto lookahead = tools::parse_subaddress_lookahead(subaddressLookahead); | ||
| if (!lookahead) | ||
| { | ||
| lookahead = tools::parse_subaddress_lookahead("5:20"); |
There was a problem hiding this comment.
Maybe std::make_pair(5,20) ?
src/wallet/api/wallet_manager.cpp
Outdated
| { | ||
| lookahead = tools::parse_subaddress_lookahead("5:20"); | ||
| } | ||
| wallet->setSubaddressLookahead(lookahead->first, lookahead->second); |
There was a problem hiding this comment.
Though with this, i'll override the wallet2 settings even when not specified. The defaults should be in wallet2 so other programs benefit from a good value.
There was a problem hiding this comment.
OK, please see the first commit.
src/wallet/wallet2.cpp
Outdated
| @@ -3269,6 +3269,12 @@ void wallet2::restore(const std::string& wallet_, const epee::wipeable_string& p | |||
| cryptonote::block b; | |||
| generate_genesis(b); | |||
| m_blockchain.push_back(get_block_hash(b)); | |||
| if (m_subaddress_lookahead_major == SUBADDRESS_LOOKAHEAD_MAJOR && m_subaddress_lookahead_major == SUBADDRESS_LOOKAHEAD_MINOR) | |||
There was a problem hiding this comment.
The second major should be minor
fb1105d to
2253b0f
Compare
moneromooo-monero
approved these changes
Jun 4, 2018
|
@stoffu please rebase. |
|
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC: @cslashm