-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to timezone database 2022b #996
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Chile, the time change is approaching very soon. We are waiting for the new version to install it.
@nickosepulveda Can the pr be merged? We would like to have the 0.5.35 version before 4.9 :) |
@ellenaua we could use your help getting this change merged and a new release published ASAP due to the DST policy change in Chile mentioned above by others. https://www.timeanddate.com/news/time/chile-dst-delay-2022.html |
Hello, we would very much appreciate this getting merged as soon as possible. We are considering whether to copy this branch into a local fork of moment-timezone to work around this. Getting this merged will save us quite some time. Cheers. |
Hi, we are affected by the timezone change in Chile which was announced two weeks ago. We can't patch our system without 2022c |
@alexmaie I went ahead and published an unofficial fork including 2022c here https://www.npmjs.com/package/moment-timezone-fork |
@lhorie thanks for the update !!! |
Hey, 0.5.36 is now released (featuring 2022c tz data). @nickosepulveda the way moment-timezone works is that you have code and you have data, and you can always provide your own (newer) data if you'd like. So next time, instead of waiting for somebody on the internet to fix things in your codebase, you can compile any data you want with There is also little need to provide a fork just for an updated data file, but ... whatever floats your boat I guess. |
Thank you @ichernev Maybe we can all take this as a wake up call to migrate away from moment :) |
@ichernev For context, we maintain a large monorepo w/ hundreds of services owned by different teams, so loading data files via code changes and then subsequently coordinating deployments for all the services is not really feasible, especially on short notice. If using Alternatively, leveraging Intl like date-fns does might be another option, if the maintainers are still willing to make code changes of that magnitude. |
No description provided.