-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patches to support 2021e and 2022c #998
Comments
@NightTsarina thank you for this patch. From my understanding the tests are auto-generated from the tz-data, so it shouldn't be necessary to manually fix them. However they fail, so the truth is out there. I'll try to sort out the tzdata generation and release a version using something more recent (like 2022c, or at least 2022a). |
There's an open PR to use 2022b (which has the same zone data as 2022c): #996 |
I appreciate the effort, but given that the data update is a pretty automated process (well it has a few shortcoming, I'm fixing them now), it makes more sense for somebody from the team to release, otherwise I have to run it anyway and check for correctness, I can't read and verify several thousand line patch by hand (and obviously I don't trust anybody :)). There should be a new release later today with |
@gilmoreorless hey, I see you're helping out with the issues. Do you want to become part of the team, moment-timezone can use some TLC (or at least a release once or twice a year :)). |
@NightTsarina country tests now pass, I had to fix them by hand, because more was needed (than your patches). I guess becuase I changed something in the pipeline... |
@ichernev I'm open to that. 😃 I'll ping you separately to avoid noise on this issue. |
No worries, I sent this just in case it was useful. I imagined there was some automated process, but I suppose I could not make it work when I started working on the Debian package.. Currently, it always uses the installed Olson DB when compiling the package, so if you could share the recipe to regenerate those tests, it would save me lots of work down the line! |
That's surprising.. they are passing here (when applied sequentially), but maybe there is some diff in the database? |
@NightTsarina hopefully running |
Right, that is what I thought :) I have been fixing them by hand for each Olson DB release for a while |
Hi, as Debian maintainer of this package, I have been manually patching the unittests to follow changes in the Olson database.
Here are the two currently applied patches against the last release of moment-timezone.
The text was updated successfully, but these errors were encountered: