Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES6 data task updates #318

Merged
merged 5 commits into from
Mar 24, 2016
Merged

ES6 data task updates #318

merged 5 commits into from
Mar 24, 2016

Conversation

timrwood
Copy link
Member

This changes the data compilation process in a few ways.

grunt data-tests

Only exports tests for the current year for each timezone. Before #82, a full battery of tests for each timezone was useful, as we were jumping through all the rules and zones and doing complicated logic. Now that we use a precomputed list and generate the tests from a precomputed list, the tests are sort of redundant.

These tests are grouped together into one file now. https://github.com/timrwood/moment-timezone/blob/es6-build-data/test/zone/changes.js This will make it easier to visually diff changes for the year for a tzdb update.

grunt data-dedupe

Move the unpacked json files into the temp folder so that they are no longer tracked in git. They weren't used for anything and made diffs noisy.

grunt data-pack

Store packed data in the src folder instead of the data folder.

src/data/archives/2016a.json
src/data/archives/2016b.json
src/data/archives/2016c.json
src/data/latest.json
src/data/latest.js
src/data/latest-2010-2020.js

grunt data-meta

Store meta data in the src folder as src/data/meta.json.

For legacy purposes, I copied the old tasks that these replaced to a similarly named task with -legacy appended. Once the conversion is complete, we can remove these tasks.

@timrwood timrwood changed the title Es6 build data ES6 data task updates Mar 24, 2016
@timrwood timrwood mentioned this pull request Mar 24, 2016
14 tasks
@timrwood timrwood merged commit d89c39d into moment:es6 Mar 24, 2016
@timrwood timrwood deleted the es6-build-data branch March 24, 2016 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant