-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to ES6 #310
Convert to ES6 #310
Conversation
Convert gruntfile and grunt tasks to es6.
* master: Version 0.5.2 2016b
ES6 data task updates
[ES6] Convert remaining moment timezone tests to ava
Any plans to offer TypeScript typings (package.json =>"typings") ? |
Why this has more info for Argentina country than master? |
@mj1856 : Hi... Any plans for a review in the near future? |
With Bower deprecated as a service, maybe the |
@timrwood How is this going? |
@mj1856 did you take over this? You need any help? I'd like this to move forward |
I'm going to close this, just because of how much time has passed. Sorry we never got it done, but sometimes life takes over. At this point, I don't plan on making changes this drastic to moment-timezone. The go-forward plan for moment and moment-timezone users is Luxon. It already has time zone support and is fully modularized ES6. |
Thanks for the feedback and recommendation, will migrate to luxon then |
This addresses #298 by converting the source into smaller es6 modules.
This is not ready to merge yet. Here are the outstanding tasks.
Some of this work can probably be done in parallel. If you want to help out, edit the description or leave a comment about which task you are working on, then open a PR to the es6 branch.
grunt data-tests
to generate correct tests. ES6 data task updates #318grunt data-pack
to outputsrc/data/packed.js
andsrc/data/packed-2010-2020.js
. ES6 data task updates #318tasks/population.json
to an es6 module insrc/data/population.js
. Convert gruntfile and grunt tasks to es6. #311data/meta/latest.json
tosrc/data/meta.js
. ES6 data task updates #318data/**/20*.json
files.src
intobuild
for different environments. (es6, globals, amd, commonjs, umd).package.json
andbower.json
to the correct file entry points.