Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to ES6 #310

Closed
wants to merge 64 commits into from
Closed

Convert to ES6 #310

wants to merge 64 commits into from

Conversation

timrwood
Copy link
Member

@timrwood timrwood commented Mar 8, 2016

This addresses #298 by converting the source into smaller es6 modules.

This is not ready to merge yet. Here are the outstanding tasks.

Some of this work can probably be done in parallel. If you want to help out, edit the description or leave a comment about which task you are working on, then open a PR to the es6 branch.

@zam6ak
Copy link

zam6ak commented Apr 22, 2016

Any plans to offer TypeScript typings (package.json =>"typings") ?

@mattjohnsonpint
Copy link
Contributor

@zam6ak see #341

@testacode
Copy link

testacode commented Mar 15, 2018

Why this has more info for Argentina country than master?
Could we add that info to the latest on master?

@brettz9
Copy link

brettz9 commented Mar 25, 2018

@mj1856 : Hi... Any plans for a review in the near future?

@brettz9
Copy link

brettz9 commented Mar 26, 2018

With Bower deprecated as a service, maybe the bower.json part of the to-dos can be dropped entirely?

@pdesjardins90
Copy link

@timrwood How is this going?

@pdesjardins90
Copy link

@mj1856 did you take over this? You need any help? I'd like this to move forward

@pdesjardins90
Copy link

@timrwood @mj1856 @ichernev @ellenaua anyone can revive this? I can help too

@mattjohnsonpint
Copy link
Contributor

I'm going to close this, just because of how much time has passed. Sorry we never got it done, but sometimes life takes over. At this point, I don't plan on making changes this drastic to moment-timezone.

The go-forward plan for moment and moment-timezone users is Luxon. It already has time zone support and is fully modularized ES6.

@pdesjardins90
Copy link

Thanks for the feedback and recommendation, will migrate to luxon then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants