Fix items scale on drop #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After drop, item 037081 remains scaled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an item is dragged it scales up but when it is released it does not scale back to normal (see attached screenshot).
This seems due to an error in the
endTouchmethod, which is responsible to scale the item back to its normal size. This method starts the animation to scale the item back but then calls thechangePositionmethod which triggers a re-render and interrupts the animation.This MR fixes this bug by moving the call to
changePositioninsideendTouchto the completion handler of the animation that scales the item back to normal size.