Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item does not scale back to normal size on drop #44

Closed
andryak opened this issue Nov 4, 2019 · 2 comments
Closed

Item does not scale back to normal size on drop #44

andryak opened this issue Nov 4, 2019 · 2 comments

Comments

@andryak
Copy link

andryak commented Nov 4, 2019

When an item is dragged it scales up but when it is released it does not scale back to normal (see attached screenshot).

This seems due to an error in the endTouch method, which is responsible to scale the item back to its normal size. This method starts the animation to scale the item back but then calls the changePosition method which triggers a re-render and interrupts the animation.

Please, review MR #43 which fixes this.

Screenshot 2019-11-04 at 16 18 54

@mochixuan
Copy link
Owner

Animations in the development environment will be compared to the card, and frame dropping may occur. You can test if there is no recovery under the release. This should not happen according to the code logic. You can test if it will appear after packaging.
Because the animation has 100ms. If you wait for the animation to finish, you may get stuck.

@leelandclay
Copy link

When I was testing, I noticed this problem and was able to get it to fail every time on an emulator by moving the mouse while the animation was finishing. While this won't happen on an actual device, I found it weird and my OCD required it to go back to normal.
Thanks for the fix @andryak I added it locally and it fixed the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants