-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buildctl: Add configured TLS certificate to trust store when making calls to registry auth #4211
Conversation
99331bd
to
f2d23db
Compare
How about add an
|
The problem is that TOML config is only for Note that theoretically, the auth requests could happen either form client or the daemon side. By default it is client, but the client can refuse and instead send the registry credentials to the daemon where it would make the auth request. This is mostly for backward compatibility as the feature of avoiding sending credentials to daemon was added later. I'd be ok with current flags but they need to take |
f2d23db
to
66ddb73
Compare
how about this way
|
@njucjc SGTM. In FYI @AkihiroSuda |
66ddb73
to
215f72c
Compare
I think create an csv flag is better, because
|
6a1b87e
to
d2b6df8
Compare
Shouldn’t we support containerd-style hosts dir? |
@AkihiroSuda TOML config is only for |
edit: sorry, I was actually referring to CRI pattern, but I don't think this is what you meant. |
I meant that the dir structure should conform to |
Let's add the flags in |
+1 |
@AkihiroSuda @tonistiigi PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Design looks good, but ~
has to be expanded to the home dir
d2b6df8
to
0bc05ff
Compare
https://github.com/moby/buildkit/actions/runs/6168240536/job/16740610078?pr=4211 |
0bc05ff
to
6a80e73
Compare
updated! @AkihiroSuda |
6a80e73
to
f071748
Compare
906c113
to
e4cfe34
Compare
…alls to registry auth Signed-off-by: njucjc <njucjc@gmail.com>
e4cfe34
to
2bd8d76
Compare
@tonistiigi @AkihiroSuda PTAL |
Add configured TLS certificate to trust store when making calls to registry auth