Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add skip tls verify configuration when fetching token from slef… #3278

Closed
wants to merge 1 commit into from

Conversation

chwetion
Copy link

add --skip-token-tls-verify flag in client to skip tls verify when fetching token.

ref issus: #3218

…-signed certificate registry

Signed-off-by: chwetion <chwetion@foxmail.com>
@chwetion chwetion force-pushed the feature-skip-token-tls-verify branch from 85a0414 to 8ba7f53 Compare November 11, 2022 07:45
@tonistiigi
Copy link
Member

What's the use case?

@chwetion
Copy link
Author

chwetion commented Nov 17, 2022

What's the use case?

private registry such as harbor or jfrog has token fetch api, these may be access via https, when buildkitd pull image from these need verify certs, add this option to skip verify

@tonistiigi
Copy link
Member

When this registry sends the token parameters with WWW-Authenticate is there anything in there that could be used to configure this? Doing this just for all hosts does not make much sense as buildctl has no way to predict what hosts the build request will use.

@liwenxiang
Copy link

I also encountered the same problem When Dockerfile FROM image is the self-signed image center.
add this parameter can ignore the HTTPS certificate error during the token request.

@ShoupingShan
Copy link

Is there any progress on this PR?

@tonistiigi
Copy link
Member

#4211 #4420 should replace this

@tonistiigi tonistiigi closed this Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants