You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
# "Could not import from scipy, which means that derivatives\n" +
# "and integrals will use less accurate finite-differencing\n" +
# "techniques. You may want to install scipy." +
# "\n" + "!" * 57 + "\n"
# )
# warnings.warn(warning_text)
derivative=fd_derivative
antiderivative=fd_indefinite_integral
indefinite_integral=fd_indefinite_integral
definite_integral=fd_definite_integral
I tried reusing test_antiderivative since fd_indefinite_integral is used to provide antiderivative if SciPy is not available, but it didn't accept the 1D input (and looking closer, test_antiderivative is really testing quaternion.calculus.spline not quaternion.calculus.antiderivative).
Unfortunately I am not familiar enough with quaternion integrals to write a suitable test to prove it, but I would guess that @jit could be replaced with @njit to future-proof the function.
The text was updated successfully, but these errors were encountered:
In the future,
numba.jit
will no longer fall back to object mode: https://numba.readthedocs.io/en/latest/reference/deprecation.html#deprecation-of-object-mode-fall-back-behaviour-when-using-jit Note that prominent deprecation warnings will be emitted in 0.57.0 (not yet released; I see them because I am currently using the latest git version of numba) and fallback support will be removed in 0.59.0.The only place where
@jit
is used is insrc/quaternion/calculus.py
forfd_indefinite_integral
:quaternion/src/quaternion/calculus.py
Lines 309 to 316 in a34a20d
All other JIT-compiled functions use
@njit
which disables object mode.There are no tests which hit this function -- it is only used if SciPy is not available:
quaternion/src/quaternion/calculus.py
Lines 461 to 481 in a34a20d
I tried reusing
test_antiderivative
sincefd_indefinite_integral
is used to provideantiderivative
if SciPy is not available, but it didn't accept the 1D input (and looking closer,test_antiderivative
is really testingquaternion.calculus.spline
notquaternion.calculus.antiderivative
).Unfortunately I am not familiar enough with quaternion integrals to write a suitable test to prove it, but I would guess that
@jit
could be replaced with@njit
to future-proof the function.The text was updated successfully, but these errors were encountered: