Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing the numba warning #189

Closed
hugohadfieldwayve opened this issue Nov 18, 2021 · 2 comments
Closed

Consider removing the numba warning #189

hugohadfieldwayve opened this issue Nov 18, 2021 · 2 comments

Comments

@hugohadfieldwayve
Copy link

Is your feature request related to a problem? Please describe.
There are scenarios in which a user would like to use this package in an environment without numba installed. By default quaternion raises a warning when it detects that numba is not present. We can squash these warnings with:

with warnings.catch_warnings():
    import quaternion

but this is annoying for the user and makes people not familiar with this package or numba think that there is something wrong with their installation and less willing to adopt it.

Would you consider changing the default behaviour to not raise the warning at all?

@moble
Copy link
Owner

moble commented Mar 31, 2022

Yep, good advice. Sorry it took so long to get around to this. :)

@hugohadfieldwayve
Copy link
Author

Thanks for the changes Mike!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants