[rubberband] add overlayed rubberband v3 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[rubberband](https://www.breakfastquay.com/rubberband/) is a small library for stretching sounds. This is the minimal portfile to make vcpkg happy, but probably still needs some improvement, i.e. not picking up system libraries.
…of the vcpkg install tree
This commit removes the rubberband 2.0.2 version from ports/rubberband to /overlay/ports/rubberband. It replaces the previous version in /overlay/ports/rubberband 1.9.0 and with that, the last 3.0.0 version is used.
|
All green, Thank you. I will merge this and issue a PR against main after the prerequisite mixxxdj/mixxx#4855 is merged. Although it would be better if one else takes final look. So if one has interest, please go ahead and review or merge it before. It will not effect our build until the main branch references the new commit hash. |
|
Okay, perfect. Thank you. |
|
microsoft#24549 (Rubberband 2.0.2) is now merged upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on the vcpkg implementation for microsoft/vcpkg by @daschuer for RubberBand v2.0.2 (see #24549). The code was used on 19 Jul. 2022 with the current PR version. It was moved into overlayed ports and replaces with the previous code. At the same time, the RubberBand version was changed to v3.0.0.