[new port] Add rubberband #24549

daschuer · 2022-05-05T09:58:38Z

rubberband is a small library for stretching sounds.
This picks up #17800

What does your PR fix?

Fixes [New Port Request] rubberband #17768

Which triplets are supported/not supported? Have you updated the CI baseline?

I have so far only tested it on my machine (linux). No I have not updated the CI baseline.

Does your PR follow the maintainer guide?

Yes

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

ports/rubberband/portfile.cmake

JackBoosY · 2022-05-06T02:35:21Z

Seems this port doesn't support uwp.

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for rubberband but no changes to version or port version.
-- Version: 2.0.2
-- Old SHA: 6b503b03aed4028b924d320c5045259a56f05bc9
-- New SHA: db6452933a7581e50c55e3ed1b6861e4f14dad8a
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

FrankXie05 · 2022-05-06T07:57:05Z

Feature test successfully in the following triplet:

x86-windows
x64-windows
x64-windows-static

BillyONeal

Want to answer the "can we use the github mirror" question; the other suggestions are nitpicks :)

ports/rubberband/portfile.cmake

daschuer · 2022-05-07T06:38:57Z

Done

github-actions

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider replacing the deprecated license identifiers in the following files:

ports/libsndfile/vcpkg.json (has deprecated license LGPL-2.1)

Deprecated and non deprecated license identifiers can be found here

daschuer · 2022-06-27T11:04:10Z

FAILED: rubberband-program.exe rubberband-program.pdb 
"C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.32.31326/bin/Hostx64/x64/link.exe"  /MACHINE:x64 /OUT:rubberband-program.exe rubberband-program.exe.p/main_main.cpp.obj rubberband-program.exe.p/src_getopt_getopt.c.obj rubberband-program.exe.p/src_getopt_getopt_long.c.obj "/nologo" "/release" "/nologo" "/DEBUG" "/PDB:rubberband-program.pdb" "-machine:x64" "-nologo" "/LIBPATH:D:/installed/x64-windows-static/debug/lib" "librubberband_objlib.a" "D:/installed/x64-windows-static/debug/lib/fftw3.lib" "D:/installed/x64-windows-static/debug/lib/samplerate.lib" "D:/installed/x64-windows-static/debug/lib/sndfile.lib" "D:/installed/x64-windows-static/debug/lib/FLAC.lib" "D:/installed/x64-windows-static/debug/lib/vorbisenc.lib" "D:/installed/x64-windows-static/debug/lib/vorbis.lib" "D:/installed/x64-windows-static/debug/lib/ogg.lib" "D:/installed/x64-windows-static/debug/lib/opus.lib" "D:/installed/x64-windows-static/debug/lib/mpg123.lib" "/LIBPATH:D:/installed/x64-windows-static/debug/lib" "mp3lame.lib" "/SUBSYSTEM:CONSOLE" "kernel32.lib" "user32.lib" "gdi32.lib" "winspool.lib" "shell32.lib" "ole32.lib" "oleaut32.lib" "uuid.lib" "comdlg32.lib" "advapi32.lib"
LINK : fatal error LNK1181: cannot open input file 'mp3lame.lib'
ninja: build stopped: subcommand failed.

daschuer · 2022-06-27T11:06:17Z

libsndfile still links against libmp3 even though the feature is now disabled for static builds.
I give up and disable static builds here instead.

…dfile dependency

BillyONeal · 2022-06-27T17:24:32Z

libsndfile still links against libmp3 even though the feature is now disabled for static builds. I give up and disable static builds here instead.

Wait, are you saying that if a feature in a downstream dependency is enabled that this breaks? That's not OK.

daschuer · 2022-06-27T19:11:25Z

Yes, even though this port required only the "default-features": false of libdndfile the mpeg feature is enabled, but broken.
Rubberband does not now emything about mp3, but it is passed to it's linker command because of that. Every executable statically linked to libdndfile suffers this issue, this nothing we can solve in this PR.

daschuer · 2022-06-27T19:13:29Z

Hey, all green finally.

BillyONeal · 2022-06-27T19:18:57Z

Yes, even though this port required only the "default-features": false of libdndfile the mpeg feature is enabled, but broken.

Then things need to be patched such that the broken path isn't touched even if someone turns on that feature.

Features are additive. Ports don't get to say "one of my transitive dependencies must be built with a feature off".

What do you mean by "enabled, but broken"?

daschuer · 2022-06-27T21:20:36Z

Then things need to be patched such that the broken path isn't touched even if someone turns on that feature.

This is currently the case. You can freely turn on and off the features nothing is breaks.

Features are additive. Ports don't get to say "one of my transitive dependencies must be built with a feature off".

This does not apply here, because the static build of feature mpeg of libsndfile itself is broken. It is unrelated to rubber-band it is broken for all. libsndfile requires to link a file which is does not exist:
LINK : fatal error LNK1181: cannot open input file 'mp3lame.lib'

What do you mean by "enabled, but broken"?

Currently no target executable is able to link libsndfile statically without explicitly disable the mpeg feature.

BillyONeal · 2022-06-27T21:33:53Z

Makes sense.

daschuer · 2022-07-12T17:57:40Z

Is this merge able now?

:)

JackBoosY · 2022-07-15T06:34:08Z

Still in reviewing.

JoergAtGithub · 2022-08-01T06:30:12Z

Still in reviewing.

@JackBoosY @FrankXie05 When can we expect an outcome of this review. It would really help, to have Rubberband as VCPKG port!

JackBoosY · 2022-09-16T08:29:23Z

Request further review.

github-actions bot approved these changes May 5, 2022

View reviewed changes

Cheney-W assigned FrankXie05 May 5, 2022

daschuer force-pushed the add_rubberband branch 2 times, most recently from 6a289db to f98e851 Compare May 5, 2022 11:22

github-actions bot approved these changes May 5, 2022

View reviewed changes

FrankXie05 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label May 6, 2022

FrankXie05 assigned JackBoosY May 6, 2022

JackBoosY suggested changes May 6, 2022

View reviewed changes

JackBoosY added the requires:author-response label May 6, 2022

daschuer force-pushed the add_rubberband branch from f98e851 to 79a9ceb Compare May 6, 2022 06:46

github-actions bot requested changes May 6, 2022

View reviewed changes

daschuer force-pushed the add_rubberband branch from 79a9ceb to 5dc58b5 Compare May 6, 2022 06:49

github-actions bot approved these changes May 6, 2022

View reviewed changes

JackBoosY changed the title ~~Add rubberband~~ [new port] Add rubberband May 6, 2022

JackBoosY previously approved these changes May 6, 2022

View reviewed changes

JackBoosY added requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function and removed requires:author-response labels May 6, 2022

FrankXie05 added info:reviewed Pull Request changes follow basic guidelines and removed requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels May 6, 2022

BillyONeal previously requested changes May 6, 2022

View reviewed changes

ports/rubberband/portfile.cmake Outdated Show resolved Hide resolved

ports/rubberband/portfile.cmake Outdated Show resolved Hide resolved

ports/rubberband/portfile.cmake Outdated Show resolved Hide resolved

BillyONeal added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels May 6, 2022

daschuer force-pushed the add_rubberband branch from 5dc58b5 to e01aede Compare May 7, 2022 06:38

github-actions bot approved these changes May 7, 2022

View reviewed changes

JackBoosY requested a review from BillyONeal May 9, 2022 06:09

JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels May 9, 2022

daschuer dismissed github-actions[bot]’s stale review via 5baeda7 June 27, 2022 09:13

daschuer force-pushed the add_rubberband branch from f602e0b to 5baeda7 Compare June 27, 2022 09:13

github-actions bot previously approved these changes Jun 27, 2022

View reviewed changes

daschuer dismissed github-actions[bot]’s stale review via ffe971a June 27, 2022 09:22

github-actions bot previously approved these changes Jun 27, 2022

View reviewed changes

[rubberband] Disable static builds on windows because of broken libsn…

a9e11ec

…dfile dependency

daschuer dismissed github-actions[bot]’s stale review via a9e11ec June 27, 2022 11:15

daschuer force-pushed the add_rubberband branch from ffe971a to a9e11ec Compare June 27, 2022 11:15

github-actions bot approved these changes Jun 27, 2022

View reviewed changes

davidchocholaty mentioned this pull request Jul 19, 2022

[rubberband] add overlayed rubberband v3 mixxxdj/vcpkg#48

Merged

FrankXie05 approved these changes Aug 5, 2022

View reviewed changes

JackBoosY added requires:author-response and removed requires:author-response labels Aug 17, 2022

JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Sep 16, 2022

dan-shaw added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Sep 19, 2022

dan-shaw merged commit 1d5b2d1 into microsoft:master Sep 22, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[new port] Add rubberband #24549

[new port] Add rubberband #24549

daschuer commented May 5, 2022

JackBoosY commented May 6, 2022

github-actions bot left a comment

FrankXie05 commented May 6, 2022

BillyONeal left a comment

daschuer commented May 7, 2022

github-actions bot left a comment

daschuer commented Jun 27, 2022

daschuer commented Jun 27, 2022

BillyONeal commented Jun 27, 2022

daschuer commented Jun 27, 2022

daschuer commented Jun 27, 2022

BillyONeal commented Jun 27, 2022

daschuer commented Jun 27, 2022

BillyONeal commented Jun 27, 2022

daschuer commented Jul 12, 2022

JackBoosY commented Jul 15, 2022

JoergAtGithub commented Aug 1, 2022

JackBoosY commented Sep 16, 2022

[new port] Add rubberband #24549

[new port] Add rubberband #24549

Conversation

daschuer commented May 5, 2022

What does your PR fix?

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

JackBoosY commented May 6, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

FrankXie05 commented May 6, 2022

BillyONeal left a comment

Choose a reason for hiding this comment

daschuer commented May 7, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

daschuer commented Jun 27, 2022

daschuer commented Jun 27, 2022

BillyONeal commented Jun 27, 2022

daschuer commented Jun 27, 2022

daschuer commented Jun 27, 2022

BillyONeal commented Jun 27, 2022

daschuer commented Jun 27, 2022

BillyONeal commented Jun 27, 2022

daschuer commented Jul 12, 2022

JackBoosY commented Jul 15, 2022

JoergAtGithub commented Aug 1, 2022

JackBoosY commented Sep 16, 2022

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?