always show tooltips in preferences #4198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25caf20 to
6b47edc
Compare
ronso0
commented
Aug 13, 2021
src/mixxxmainwindow.cpp
Outdated
| switch (m_toolTipsCfg) { | ||
| // always show tooltips in the preferences window | ||
| QWidget* actWin = QApplication::activeWindow(); | ||
| if (actWin && QLatin1String(actWin->metaObject()->className()) != "DlgPreferences") { |
There was a problem hiding this comment.
that could also be
if (actWin && actWin->objectName() != "DlgPreferencesDlg")both work, I don't know what's preferred. Also, I didn't manage to cast char to QString, the attempts were rather elaborate for a string comparison.
This comment has been minimized.
This comment has been minimized.
|
Rebase on 2.3? |
6b47edc to
eac5995
Compare
why not. any comment on the code? |
Be-ing
reviewed
Aug 25, 2021
eac5995 to
c706e2e
Compare
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.launchpad.net/mixxx/+bug/1840493