Merge pull request #4198 from ronso0/tooltips-in-preferences

always show tooltips in preferences
mixxxdj · Aug 26, 2021 · c8c0df4 · c8c0df4
2 parents 10031e0 + c706e2e
commit c8c0df4
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/src/mixxx.cpp b/src/mixxx.cpp
@@ -1606,8 +1606,13 @@ void MixxxMainWindow::rebootMixxxView() {
 
 bool MixxxMainWindow::eventFilter(QObject* obj, QEvent* event) {
     if (event->type() == QEvent::ToolTip) {
-        // return true for no tool tips
-        switch (m_toolTipsCfg) {
+        // always show tooltips in the preferences window
+        QWidget* activeWindow = QApplication::activeWindow();
+        if (activeWindow &&
+                QLatin1String(activeWindow->metaObject()->className()) !=
+                        "DlgPreferences") {
+            // return true for no tool tips
+            switch (m_toolTipsCfg) {
             case mixxx::TooltipsPreference::TOOLTIPS_ONLY_IN_LIBRARY:
                 if (dynamic_cast<WBaseWidget*>(obj) != nullptr) {
                     return true;
@@ -1620,6 +1625,7 @@ bool MixxxMainWindow::eventFilter(QObject* obj, QEvent* event) {
             default:
                 DEBUG_ASSERT(!"m_toolTipsCfg value unknown");
                 return true;
+            }
         }
     }
     // standard event processing