Sync Lock: Don't seek phase when disabling sync #4169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1087668649
💛 - Coveralls |
|
Ist the main target branch correct? Or does this affect 2.3? |
daschuer
reviewed
Aug 1, 2021
| @@ -389,6 +393,7 @@ class EngineBuffer : public EngineObject { | |||
| QAtomicInt m_iEnableSyncQueued; | |||
| QAtomicInt m_iSyncModeQueued; | |||
| ControlValueAtomic<QueuedSeek> m_queuedSeek; | |||
| bool m_previousBufferSeek = false; | |||
There was a problem hiding this comment.
If this is accessed from multiple threads it should be an atomic for proper memory barriers.
There was a problem hiding this comment.
It isn't, this value is only written in the processSeek function and used by tests in a non-threaded context
daschuer
requested changes
Aug 1, 2021
|
anything more needed here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.