skin preview: consider devicePixelRatio when scaling #3941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
daschuer
reviewed
Jun 4, 2021
src/skin/skinloader.cpp
Outdated
| preview = preview.scaled(QSize(640, 360), Qt::KeepAspectRatio, Qt::SmoothTransformation); | ||
| QSize scaledSize(static_cast<int>(640 * devicePixelRatio), | ||
| static_cast<int>(360 * devicePixelRatio)); | ||
| preview.setDevicePixelRatio(devicePixelRatio); |
There was a problem hiding this comment.
nope. without line79 the image would just be as big as set by the QSize.
There was a problem hiding this comment.
whoops, you refer to the duplicate setDevicePixelRatio line above the code quote here.
yes, that's unnnecessary.
fixed.
daschuer
reviewed
Jun 4, 2021
src/skin/skinloader.cpp
Outdated
| QSize scaledSize(static_cast<int>(640 * devicePixelRatio), | ||
| static_cast<int>(360 * devicePixelRatio)); | ||
| preview.setDevicePixelRatio(devicePixelRatio); | ||
| preview = preview.scaled(scaledSize, Qt::KeepAspectRatio, Qt::SmoothTransformation); |
There was a problem hiding this comment.
This can be shortened to
Suggested change
| preview = preview.scaled(scaledSize, Qt::KeepAspectRatio, Qt::SmoothTransformation); | |
| preview = preview.scaled(QSize(640, 360) * devicePixelRatio, Qt::KeepAspectRatio, Qt::SmoothTransformation); |
There was a problem hiding this comment.
I didn't find docu on how to scale a QSize with just a factor. did you try it?
if yes, feel free to push the shorter version.
There was a problem hiding this comment.
I didn't find docu on how to scale a QSize with just a factor.
ywwg
approved these changes
Jun 4, 2021
|
Thanks for the quick review. Ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up for #3926
fixes blurry preview images.
before
this PR (not ethat you can now read the library : ) try with
QT_SCALE_FACTORS=3for full effect