Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview resize #3926

Merged
merged 2 commits into from
May 31, 2021
Merged

Preview resize #3926

merged 2 commits into from
May 31, 2021

Conversation

ywwg
Copy link
Member

@ywwg ywwg commented May 29, 2021

No description provided.

@github-actions github-actions bot added the skins label May 29, 2021
@ywwg ywwg force-pushed the preview-resize branch from 8e074d4 to 0429d41 Compare May 29, 2021 20:30
@ywwg ywwg changed the base branch from main to 2.3 May 29, 2021 20:30
@ywwg ywwg force-pushed the preview-resize branch from 0429d41 to dd00171 Compare May 29, 2021 20:31
@ronso0 ronso0 added this to the 2.3.0 milestone May 29, 2021
ronso0
ronso0 requested changes May 29, 2021
View reviewed changes
src/skin/skinloader.cpp Outdated Show resolved Hide resolved
@ronso0
Copy link
Member

ronso0 commented May 29, 2021

we should re-create all skin previews when this is merged. Right now they're blurry already due to odd resizing from minimal skin size to 445 x 250 px.
we can take the new, yet to be made 4k screenshots from the website and scale the down to 1920px
https://mixxx.zulipchat.com/#narrow/stream/109171-development/topic/2.2E3.20planning.3A.20https.3A.2F.2Fgithub.2Ecom.2Fmixxxdj.2Fmixxx.2Fprojects.2F2/near/240724451

@ywwg
Copy link
Member Author

ywwg commented May 30, 2021

Yes I like that idea

@ywwg @ronso0
Preview resize: also resize the placeholder
60aa7a1 
Co-authored-by: ronso0 <ronso0@mixxx.org>
@ywwg
Copy link
Member Author

ywwg commented May 31, 2021

good to merge?

@ronso0
Copy link
Member

ronso0 commented May 31, 2021

let's wait for CI..

@ronso0
Copy link
Member

ronso0 commented May 31, 2021

LGTM, thank you!

@ronso0 ronso0 merged commit f97ff5d into mixxxdj:2.3 May 31, 2021
@ronso0 ronso0 mentioned this pull request Jun 4, 2021
Merged
@ronso0
Copy link
Member

ronso0 commented Jun 4, 2021

Unfotunately the previews are blurry when Mixxx is scaled uo, even when using integer values.
fixed with #3941

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronso0 ronso0 ronso0 requested changes

Assignees
No one assigned
Labels
blocker skins
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ywwg @ronso0 @uklotzde